Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gatsby] "https://facebook.github.io/react/" -> "https://reactjs.org/" #10970

Merged
merged 1 commit into from
Sep 30, 2017

Conversation

skratchdot
Copy link
Contributor

Not sure this change is wanted (or too excessive). The biggest question I had is whether it was okay to update old changelog links. I smoke tested a few of the link changes, and everything seems to be working.

@skratchdot
Copy link
Contributor Author

2 other questionable changes from this pr:

@reactjs-bot
Copy link

Deploy preview ready!

Built with commit 50c2afc

https://deploy-preview-10970--reactjs.netlify.com

@skratchdot
Copy link
Contributor Author

og:url are still showing undefined (but they are doing that in the currently deployed version.

<meta data-react-helmet="true" property="og:url" content="undefined/index.md"/>

@bvaughn
Copy link
Contributor

bvaughn commented Sep 29, 2017

The biggest question I had is whether it was okay to update old changelog links.

Yeah, I think this is reasonable.

2 other questionable changes from this pr:

  • docs/_config.yml
  • docs/_layouts/default.html (the og:url link - will it generate links with extraneous slashes?)

Don't worry about changes to docs/_layouts/default.html. This is used for the old Jekyll site which the new site has replaced.

og:url are still showing undefined (but they are doing that in the currently deployed version.

og:url does not show as undefined for me (on the live site) although it does show the incorrect file extensions (.md instead of .html). This should hopefully be fixed by #10902 (or similar).

@skratchdot
Copy link
Contributor Author

skratchdot commented Sep 29, 2017

@bvaughn - I missed a nuance in the og:url. If you view the generated dom after js kicks in (and react-helmet updates the url), then I see reactjs.org. I was using "view-source", so it was showing up as undefined. This is probably something that can be fixed in the gatsby build (but I've never used gatsby). I'll try to see if there's anything that can be done. Probably not a big deal in the short term.

edit: looks like the og:url stuff is fixed in: #10902

@@ -16,7 +16,7 @@ var invariant = require('fbjs/lib/invariant');
* Returns the first child in a collection of children and verifies that there
* is only one child in the collection.
*
* See https://facebook.github.io/react/docs/react-api.html#react.children.only
* See https://reactjs.org/docs/react-api.html#react.children.only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of these anchor tags are invalid b'c of how Gatsby handles them. For instance, this one should now be: reactjs.org/docs/react-api.html#reactchildrenonly

But this is not related to this PR 😄 Just mentioning it in passing.

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 😄 Thank you for making these changes

@bvaughn bvaughn merged commit 0344f7a into facebook:master Sep 30, 2017
NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants