-
Notifications
You must be signed in to change notification settings - Fork 47.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gatsby] "https://facebook.github.io/react/" -> "https://reactjs.org/" #10970
Conversation
2 other questionable changes from this pr:
|
Deploy preview ready! Built with commit 50c2afc |
|
Yeah, I think this is reasonable.
Don't worry about changes to
|
@bvaughn - I missed a nuance in the edit: looks like the |
@@ -16,7 +16,7 @@ var invariant = require('fbjs/lib/invariant'); | |||
* Returns the first child in a collection of children and verifies that there | |||
* is only one child in the collection. | |||
* | |||
* See https://facebook.github.io/react/docs/react-api.html#react.children.only | |||
* See https://reactjs.org/docs/react-api.html#react.children.only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of these anchor tags are invalid b'c of how Gatsby handles them. For instance, this one should now be: reactjs.org/docs/react-api.html#reactchildrenonly
But this is not related to this PR 😄 Just mentioning it in passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good 😄 Thank you for making these changes
Not sure this change is wanted (or too excessive). The biggest question I had is whether it was okay to update old changelog links. I smoke tested a few of the link changes, and everything seems to be working.