Unify context implementations #13140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, context can only be read by a special type of component, ContextConsumer. We want to add support to all fibers, including classes and functional components. Each fiber may read from one or more contexts. To enable quick, mono- morphic access of this list, we'll store them on a fiber property.
unstable_read can be called anywhere within the render phase. That includes the render method, getDerivedStateFromProps, constructors, functional components, and context consumer render props. If it's called outside the render phase, an error is thrown.
|
React: size: 🔺+2.4%, gzip: 🔺+1.7% ReactDOM: size: 🔺+0.8%, gzip: 🔺+0.7% Details of bundled changes.Comparing: 6731bfb...eb84045 react
react-dom
react-art
react-test-renderer
react-reconciler
react-native-renderer
Generated by 🚫 dangerJS |
acdlite
force-pushed
the
unifycontext-2
branch
4 times, most recently
from
fe64cbd to
fe9e602
Compare
Implements the legacy, string-based context API on top of the new context API. This doesn't save much in code size because most of the legacy stuff deals with merging and masking. Arguably, it's a conceptual complexity win. I'm ambivalent about whether we land this.
Doing this in a separate commit so the diff is less confusing
|
Would this break unstable_renderSubtreeIntoContainer (#12493)? |
|
@sophiebits 🤔I was commenting on the wrong issue in the morning. I had the very same question here: #13139 (comment) (just want to link it for completeness) |
sebmarkbage
requested changes
Jul 4, 2018
|
To clarify, it’s not a breaking change. In my comment above I meant that we don’t plan to make |
|
But I’d also prefer to just deprecate legacy context :D |
5 tasks
|
Not worth it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #13139
Implements the legacy, string-based context API on top of the new context API. This doesn't save much in code size because most of the legacy stuff deals with merging and masking. Arguably, it's a conceptual complexity win.
I'm ambivalent about whether we land this.