-
Notifications
You must be signed in to change notification settings - Fork 47.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React events: add onHoverMove support #15388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left feedback on hover move being discrete. Also we should probably add onUnmount
support to the Hover module to make it unsubscribe from events properly at some point too.
05a5bf6
to
6bf944a
Compare
6bf944a
to
bb9988d
Compare
Details of bundled changes.Comparing: cdfb06e...bb9988d react-events
Generated by 🚫 dangerJS |
Is it really OK that it does not respect the shape of an element? Suppose we have an element with |
Adds
onHoverMove
, related test, and documentation.Ref #15257