Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Event API: various bug fixes with HitTargets #15485

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Apr 24, 2019

This PR contains a selection of bug fixes for the experimental event API. Notably:

  • The commitEventTarget and onMount renderer callbacks are now called during the lifecycle phase so that we now can properly access the element after it's been attached to the document.
  • Fixed a typo in detection of zIndex checking.
  • Updated all tests to properly account for the functionality now working correctly.
  • Fixed Press handling of hit targets. It was broken before and was allowing mouse and pen events to incorrectly trigger the event target. Furthermore, the focus event is now correctly blocked.

@sizebot
Copy link

sizebot commented Apr 24, 2019

ReactDOM: size: 0.0%, gzip: 0.0%

Details of bundled changes.

Comparing: fb28e90...1ce2329

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% 0.0% 815.71 KB 815.95 KB 185.93 KB 185.98 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 103.68 KB 103.69 KB 33.68 KB 33.69 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 106.83 KB 106.84 KB 34.66 KB 34.67 KB UMD_PROFILING
react-dom.development.js 0.0% 0.0% 810.19 KB 810.44 KB 184.4 KB 184.45 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 103.67 KB 103.69 KB 33.13 KB 33.14 KB NODE_PROD
react-dom.profiling.min.js 0.0% 0.0% 107 KB 107.01 KB 33.98 KB 33.98 KB NODE_PROFILING
ReactDOM-dev.js 0.0% 0.0% 834.47 KB 834.71 KB 185.8 KB 185.85 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+0.2% 🔺+0.2% 340.71 KB 341.26 KB 63.13 KB 63.22 KB FB_WWW_PROD
ReactDOM-profiling.js +0.2% +0.2% 346.12 KB 346.66 KB 64.04 KB 64.19 KB FB_WWW_PROFILING
react-dom-unstable-fire.development.js 0.0% 0.0% 816.04 KB 816.28 KB 186.07 KB 186.12 KB UMD_DEV
react-dom-unstable-fire.production.min.js 0.0% 0.0% 103.69 KB 103.71 KB 33.69 KB 33.7 KB UMD_PROD
react-dom-unstable-fire.profiling.min.js 0.0% 0.0% 106.84 KB 106.85 KB 34.67 KB 34.68 KB UMD_PROFILING
react-dom-unstable-fire.development.js 0.0% 0.0% 810.52 KB 810.76 KB 184.54 KB 184.59 KB NODE_DEV
react-dom-unstable-fire.production.min.js 0.0% 0.0% 103.69 KB 103.7 KB 33.14 KB 33.15 KB NODE_PROD
react-dom-unstable-fire.profiling.min.js 0.0% 0.0% 107.01 KB 107.03 KB 33.99 KB 33.99 KB NODE_PROFILING
ReactFire-dev.js 0.0% 0.0% 833.66 KB 833.89 KB 185.78 KB 185.84 KB FB_WWW_DEV
ReactFire-prod.js 🔺+0.2% 🔺+0.2% 328.71 KB 329.26 KB 60.72 KB 60.83 KB FB_WWW_PROD
ReactFire-profiling.js +0.2% +0.2% 334.09 KB 334.62 KB 61.66 KB 61.79 KB FB_WWW_PROFILING
react-dom-test-utils.development.js 0.0% -0.0% 54.19 KB 54.19 KB 14.98 KB 14.98 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.42 KB 10.42 KB 3.57 KB 3.56 KB NODE_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 19.18 KB 19.18 KB 7.21 KB 7.21 KB UMD_PROD
react-dom-server.browser.development.js 0.0% -0.0% 132.86 KB 132.86 KB 34.99 KB 34.99 KB NODE_DEV
ReactDOMServer-prod.js 0.0% -0.0% 47.14 KB 47.14 KB 10.8 KB 10.8 KB FB_WWW_PROD
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.66 KB 3.66 KB 1.45 KB 1.45 KB UMD_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 3.74 KB 3.74 KB 1.43 KB 1.43 KB NODE_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.1% 1.1 KB 1.1 KB 667 B 668 B NODE_PROD

react-events

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-events.development.js 0.0% +0.1% 1.59 KB 1.59 KB 687 B 688 B UMD_DEV
react-events.production.min.js 0.0% 🔺+0.2% 857 B 857 B 476 B 477 B UMD_PROD
react-events.development.js 0.0% +0.2% 1.4 KB 1.4 KB 625 B 626 B NODE_DEV
react-events.production.min.js 0.0% 🔺+0.3% 698 B 698 B 400 B 401 B NODE_PROD
react-events-press.development.js +1.9% +2.2% 17.23 KB 17.57 KB 4.39 KB 4.48 KB UMD_DEV
react-events-press.production.min.js 🔺+0.8% 🔺+0.7% 6.75 KB 6.8 KB 2.55 KB 2.57 KB UMD_PROD
react-events-press.development.js +2.0% +2.2% 17.06 KB 17.4 KB 4.35 KB 4.45 KB NODE_DEV
react-events-press.production.min.js 🔺+0.8% 🔺+0.7% 6.59 KB 6.64 KB 2.49 KB 2.51 KB NODE_PROD
ReactEventsPress-dev.js +2.1% +2.6% 15.13 KB 15.46 KB 3.61 KB 3.71 KB FB_WWW_DEV
ReactEventsPress-prod.js 🔺+1.6% 🔺+0.8% 12.91 KB 13.11 KB 2.84 KB 2.86 KB FB_WWW_PROD
react-events-swipe.production.min.js 0.0% 🔺+0.1% 3.52 KB 3.52 KB 1.61 KB 1.61 KB UMD_PROD
react-events-swipe.development.js 0.0% -0.0% 8.23 KB 8.23 KB 2.54 KB 2.54 KB NODE_DEV
react-events-swipe.production.min.js 0.0% 🔺+0.1% 3.36 KB 3.36 KB 1.55 KB 1.55 KB NODE_PROD
react-events-drag.development.js 0.0% 0.0% 7.95 KB 7.95 KB 2.46 KB 2.46 KB UMD_DEV
react-events-drag.production.min.js 0.0% 🔺+0.1% 3.38 KB 3.38 KB 1.53 KB 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@trueadm trueadm merged commit 3f058de into facebook:master Apr 24, 2019
@trueadm trueadm deleted the various-event-fixes branch April 24, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants