Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guard to ensure Profiler onRender prop is function before calling #16197

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Add guard to ensure Profiler onRender prop is function before calling #16197

merged 1 commit into from
Jul 24, 2019

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jul 24, 2019

FYI we already warn in DEV when creating the Fiber:

Profiler must specify an "id" string and "onRender" function as props

@bvaughn bvaughn requested a review from sebmarkbage July 24, 2019 21:14
@sizebot
Copy link

sizebot commented Jul 24, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS

@bvaughn bvaughn merged commit 9ae5e38 into facebook:master Jul 24, 2019
@bvaughn bvaughn deleted the check-profiler-onrender-type-before-caling branch July 24, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bvaughn @sizebot @sebmarkbage