Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-interaction] Refactor a11y components more #16866

Merged
merged 1 commit into from
Sep 23, 2019
Merged

[react-interaction] Refactor a11y components more #16866

merged 1 commit into from
Sep 23, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Sep 23, 2019

After some internal discussion around the React Interactions a11y components (for internal use only), it was made clear that we should be able to define the scope for these components.

  • FocusTable now accepts a scope implementation on createFocusTable factory function.
  • TabFocusController is now TabFocus
  • The focus controller methods are now broken out into their own file
  • TabFocus now accepts a ReactScope as a prop to be used

@trueadm trueadm requested a review from necolas September 23, 2019 18:26
@trueadm trueadm force-pushed the refactor_a11y_components branch from 15bb5ec to 16ec67e Compare September 23, 2019 18:27
@sizebot
Copy link

sizebot commented Sep 23, 2019 •
edited
Loading

Details of bundled changes.

Comparing: 312b462...8e27ba7

react-interactions

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-interactions-events/focus.development.js 0.0% -0.1% 10.93 KB 10.93 KB 2.36 KB 2.36 KB UMD_DEV
react-interactions-events/press.development.js 0.0% -0.1% 5.03 KB 5.03 KB 1.43 KB 1.43 KB UMD_DEV
react-interactions-events/tap.development.js 0.0% -0.0% 17.52 KB 17.52 KB 3.74 KB 3.74 KB UMD_DEV
react-interactions-events/focus.production.min.js 0.0% -0.1% 4.1 KB 4.1 KB 1.39 KB 1.39 KB UMD_PROD
react-interactions-events/press.production.min.js 0.0% -0.1% 2.25 KB 2.25 KB 984 B 983 B UMD_PROD
react-interactions-events/tap.production.min.js 0.0% -0.1% 6.23 KB 6.23 KB 2.35 KB 2.35 KB UMD_PROD
ReactFocusTable-dev.js -1.1% -1.1% 6.79 KB 6.71 KB 1.6 KB 1.58 KB FB_WWW_DEV
react-interactions-events/context-menu.development.js 0.0% -0.1% 2.68 KB 2.68 KB 1007 B 1006 B UMD_DEV
react-interactions-events/input.development.js 0.0% -0.1% 4.52 KB 4.52 KB 1.45 KB 1.44 KB UMD_DEV
react-interactions-events/scroll.development.js 0.0% -0.1% 6.3 KB 6.3 KB 1.65 KB 1.65 KB UMD_DEV
react-interactions-events/context-menu.production.min.js 0.0% -0.3% 1.39 KB 1.39 KB 730 B 728 B UMD_PROD
react-interactions-events/input.production.min.js 0.0% -0.3% 1.84 KB 1.84 KB 986 B 983 B UMD_PROD
react-interactions-events/scroll.production.min.js 0.0% -0.2% 2.63 KB 2.63 KB 1.15 KB 1.15 KB UMD_PROD
ReactFocusControl-dev.js n/a n/a 0 B 3.52 KB 0 B 908 B FB_WWW_DEV
ReactFocusControl-prod.js n/a n/a 0 B 2.75 KB 0 B 792 B FB_WWW_PROD
react-interactions-events/context-menu.development.js 0.0% -0.2% 2.49 KB 2.49 KB 962 B 960 B NODE_DEV
react-interactions-events/input.development.js 0.0% -0.1% 4.34 KB 4.34 KB 1.4 KB 1.4 KB NODE_DEV
react-interactions-events/scroll.development.js 0.0% -0.1% 6.12 KB 6.12 KB 1.61 KB 1.61 KB NODE_DEV
react-interactions-accessibility/tab-focus.development.js -66.2% -42.6% 4.79 KB 1.62 KB 1.25 KB 737 B NODE_DEV
react-interactions-events/context-menu.production.min.js 0.0% -0.3% 1.2 KB 1.2 KB 669 B 667 B NODE_PROD
react-interactions-events/input.production.min.js 0.0% -0.2% 1.66 KB 1.66 KB 918 B 916 B NODE_PROD
react-interactions-events/scroll.production.min.js 0.0% -0.2% 2.44 KB 2.44 KB 1.09 KB 1.09 KB NODE_PROD
react-interactions-accessibility/tab-focus.production.min.js -53.6% -37.4% 1.79 KB 852 B 856 B 536 B NODE_PROD
react-interactions-events/hover.development.js 0.0% -0.1% 7 KB 7 KB 1.56 KB 1.55 KB UMD_DEV
react-interactions-events/press-legacy.development.js 0.0% -0.0% 20.74 KB 20.74 KB 4.83 KB 4.83 KB UMD_DEV
react-interactions-events/hover.production.min.js 0.0% -0.2% 3.12 KB 3.12 KB 1.13 KB 1.13 KB UMD_PROD
react-interactions-events/press-legacy.production.min.js 0.0% -0.0% 6.98 KB 6.98 KB 2.63 KB 2.63 KB UMD_PROD
ReactTabFocus-dev.js -66.7% -44.1% 4.77 KB 1.59 KB 1.21 KB 695 B FB_WWW_DEV
ReactTabFocus-prod.js -64.1% -44.2% 3.85 KB 1.38 KB 1.11 KB 632 B FB_WWW_PROD
react-interactions-events/hover.development.js 0.0% -0.1% 6.82 KB 6.82 KB 1.51 KB 1.51 KB NODE_DEV
react-interactions-events/press-legacy.development.js 0.0% -0.0% 20.55 KB 20.55 KB 4.78 KB 4.78 KB NODE_DEV
react-interactions-accessibility/focus-table.development.js -1.2% -1.1% 6.97 KB 6.88 KB 1.65 KB 1.63 KB NODE_DEV
react-interactions-events/hover.production.min.js 0.0% -0.3% 2.94 KB 2.94 KB 1.08 KB 1.07 KB NODE_PROD
react-interactions-events/press-legacy.production.min.js 0.0% -0.0% 6.8 KB 6.8 KB 2.57 KB 2.57 KB NODE_PROD
react-interactions-accessibility/focus-table.production.min.js -3.2% -2.7% 2.39 KB 2.31 KB 1 KB 1001 B NODE_PROD
ReactFocusTable-prod.js -1.3% -1.5% 6.21 KB 6.13 KB 1.4 KB 1.38 KB FB_WWW_PROD
react-interactions-events/focus.development.js 0.0% -0.1% 10.74 KB 10.74 KB 2.32 KB 2.32 KB NODE_DEV
react-interactions-events/press.development.js 0.0% -0.1% 4.74 KB 4.74 KB 1.36 KB 1.36 KB NODE_DEV
react-interactions-accessibility/tabbable-scope.development.js +5.4% +3.6% 1.18 KB 1.24 KB 585 B 606 B NODE_DEV
react-interactions-events/focus.production.min.js 0.0% -0.2% 3.93 KB 3.93 KB 1.33 KB 1.32 KB NODE_PROD
react-interactions-events/press.production.min.js 0.0% -0.2% 1.96 KB 1.96 KB 890 B 888 B NODE_PROD
react-interactions-events/tap.production.min.js 0.0% -0.0% 6.06 KB 6.06 KB 2.3 KB 2.3 KB NODE_PROD
react-interactions-accessibility/tabbable-scope.production.min.js 🔺+0.6% 🔺+0.9% 680 B 684 B 448 B 452 B NODE_PROD
react-interactions-events/drag.development.js 0.0% -0.1% 5.23 KB 5.23 KB 1.54 KB 1.54 KB UMD_DEV
react-interactions-events/swipe.development.js 0.0% -0.1% 6 KB 6 KB 1.63 KB 1.63 KB UMD_DEV
react-interactions-events/drag.production.min.js 0.0% -0.2% 2.25 KB 2.25 KB 1.07 KB 1.07 KB UMD_PROD
react-interactions-events/keyboard.production.min.js 0.0% -0.1% 2.41 KB 2.41 KB 1.21 KB 1.21 KB UMD_PROD
react-interactions-events/swipe.production.min.js 0.0% -0.2% 2.45 KB 2.45 KB 1.11 KB 1.11 KB UMD_PROD
ReactTabbableScope-dev.js +5.3% +4.2% 1.15 KB 1.21 KB 554 B 577 B FB_WWW_DEV
ReactTabbableScope-prod.js 🔺+7.7% 🔺+5.0% 980 B 1.03 KB 476 B 500 B FB_WWW_PROD
react-interactions-events/drag.development.js 0.0% -0.1% 6.98 KB 6.98 KB 2.21 KB 2.21 KB NODE_DEV
react-interactions-events/swipe.development.js 0.0% -0.1% 5.82 KB 5.82 KB 1.58 KB 1.58 KB NODE_DEV
react-interactions-accessibility/focus-control.development.js n/a n/a 0 B 3.56 KB 0 B 950 B NODE_DEV
react-interactions-events/drag.production.min.js 0.0% -0.1% 2.88 KB 2.88 KB 1.38 KB 1.38 KB NODE_PROD
react-interactions-events/swipe.production.min.js 0.0% -0.2% 2.27 KB 2.27 KB 1.05 KB 1.05 KB NODE_PROD
react-interactions-accessibility/focus-control.production.min.js n/a n/a 0 B 1.26 KB 0 B 616 B NODE_PROD

Generated by 🚫 dangerJS against 8e27ba7

@trueadm trueadm force-pushed the refactor_a11y_components branch from 16ec67e to 8e27ba7 Compare September 23, 2019 18:34
@trueadm trueadm merged commit 1a6294d into facebook:master Sep 23, 2019
@trueadm trueadm deleted the refactor_a11y_components branch September 23, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@necolas necolas necolas approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trueadm @sizebot @necolas @facebook-github-bot