Fix release script artifact path. #17972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Circle CI seems to have changed the reported artifact path which broke our scripts.
facebook-github-bot
added
React Core Team
gaearon
approved these changes
Feb 4, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b4be022:
|
threepointone
added a commit
to threepointone/react
that referenced
this pull request
Feb 4, 2020
similar to facebook#17972, this should fix sizebot not reporting stats right now
bvaughn
pushed a commit
that referenced
this pull request
Feb 4, 2020
similar to #17972, this should fix sizebot not reporting stats right now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Circle CI seems to have changed the reported artifact path which broke our scripts. I noticed this morning that older builds (e.g. 77063) were able to be downloaded but newer builds (e.g. 82919) were not.
Tracing through this...
77063
"home/circleci/project/node_modules.tgz"82919
"node_modules.tgz"So...something changed how they report the path (presumably on Circle CI's side). This PR updates our release script to be a little more loose in how it identifies that artifact.