Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable enableProfilerNestedUpdateScheduledHook in profiling builds #21566

Closed

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented May 25, 2021

For consideration, enable the enableProfilerNestedUpdateScheduledHook flag (#20211). This API is a little more nuanced/controversial but has been helpful for advanced performance tracking within Facebook.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 25, 2021
@sizebot
Copy link

sizebot commented May 25, 2021

Comparing: 0ae5290...e45414d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 126.00 kB 126.00 kB = 40.41 kB 40.41 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 128.82 kB 128.82 kB = 41.35 kB 41.35 kB
facebook-www/ReactDOM-prod.classic.js = 406.09 kB 406.09 kB = 75.11 kB 75.11 kB
facebook-www/ReactDOM-prod.modern.js = 394.46 kB 394.46 kB = 73.29 kB 73.29 kB
facebook-www/ReactDOMForked-prod.classic.js = 406.09 kB 406.09 kB = 75.11 kB 75.11 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js +0.27% 245.25 kB 245.92 kB +0.29% 45.11 kB 45.24 kB
react-native/implementations/ReactFabric-profiling.js +0.24% 278.02 kB 278.69 kB +0.26% 49.78 kB 49.90 kB
react-native/implementations/ReactFabric-profiling.fb.js +0.24% 278.06 kB 278.73 kB +0.27% 49.76 kB 49.89 kB
react-native/implementations/ReactNativeRenderer-profiling.js +0.24% 284.97 kB 285.64 kB +0.25% 51.18 kB 51.31 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js +0.24% 285.00 kB 285.67 kB +0.25% 51.17 kB 51.29 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js +0.21% 609.16 kB 610.46 kB +0.24% 132.42 kB 132.73 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js +0.21% 597.45 kB 598.72 kB +0.22% 131.36 kB 131.65 kB
oss-stable/react-test-renderer/umd/react-test-renderer.development.js +0.21% 626.65 kB 627.98 kB +0.23% 132.79 kB 133.09 kB
facebook-www/ReactTestRenderer-dev.classic.js +0.21% 621.83 kB 623.13 kB +0.22% 133.96 kB 134.25 kB
facebook-www/ReactTestRenderer-dev.modern.js +0.21% 621.84 kB 623.14 kB +0.22% 133.96 kB 134.26 kB
oss-stable/react-art/cjs/react-art.development.js +0.21% 611.06 kB 612.33 kB +0.21% 133.65 kB 133.93 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js +0.21% 613.38 kB 614.65 kB +0.22% 134.71 kB 135.00 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.development.js +0.21% 643.43 kB 644.75 kB +0.22% 136.20 kB 136.49 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.min.js +0.20% 92.94 kB 93.12 kB +0.27% 28.65 kB 28.73 kB
oss-experimental/react-art/cjs/react-art.development.js +0.20% 633.52 kB 634.79 kB +0.21% 138.30 kB 138.59 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 42.24 kB 42.13 kB = 11.82 kB 11.80 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 42.24 kB 42.13 kB = 11.82 kB 11.80 kB
facebook-www/ReactIs-dev.classic.js = 10.17 kB 10.06 kB = 2.73 kB 2.71 kB
facebook-www/ReactIs-dev.modern.js = 10.17 kB 10.06 kB = 2.73 kB 2.71 kB

Generated by 🚫 dangerJS against e45414d

@bvaughn bvaughn closed this May 25, 2021
@dinkinflickaa
Copy link

@bvaughn , I realize this PR is quite old. Do you happen to recall why it wasn't merged into the main branch? I wanted to utilize this flag for tracking nested updates. However, before exploring that, it'd be helpful to understand if there were any concerns with this callback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants