Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hasOwnProperty to devTools backend #22437

Merged
merged 1 commit into from
Sep 27, 2021
Merged

add hasOwnProperty to devTools backend #22437

merged 1 commit into from
Sep 27, 2021

Conversation

behnammodi
Copy link
Contributor

We always use hasOwnProperty from shared package like isArray, so I think this case is missed

@bvaughn

bvaughn
bvaughn approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't really missed. React (reconciler/renderer) packages and DevTools packages follow slightly different rules and conventions.

That being said, this change seems fine :)

@bvaughn bvaughn merged commit c9d64e5 into facebook:main Sep 27, 2021
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
@behnammodi @zhengjitf
add hasOwnProperty to devTools backend (facebook#22437)
daec1ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@behnammodi @bvaughn @facebook-github-bot