Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Updated link in CONTRIBUTING #25381

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Fix: Updated link in CONTRIBUTING #25381

merged 1 commit into from
Oct 3, 2022
+1 −1

Conversation

KirankumarAmbati
Copy link
Contributor

Summary

How did you test this change?

It is a url link change.

RaheemAmer
RaheemAmer reviewed Oct 2, 2022
View reviewed changes
Copy link

@RaheemAmer RaheemAmer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this PR looks good to me but as for CircleCI Pipeline I have no idea

@kassens
Copy link
Member

kassens commented Oct 3, 2022

Thank you, can't see how this should've broken CI.

@kassens kassens merged commit 2d80a0c into facebook:main Oct 3, 2022
@KirankumarAmbati KirankumarAmbati deleted the patch-2 branch October 3, 2022 15:22
@KirankumarAmbati
Copy link
Contributor Author

@kassens: It might be too much of an ask but would you mind adding hacktoberfest-accepted label so that this PR would be considered for Hacktoberfest. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaheemAmer RaheemAmer RaheemAmer left review comments

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KirankumarAmbati @kassens @RaheemAmer @facebook-github-bot