Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 14-communicate-between-components.md for grammatical changes #2760

Merged
merged 1 commit into from
Dec 22, 2014

Conversation

alextsg
Copy link
Contributor

@alextsg alextsg commented Dec 21, 2014

Update to improve grammatical parallelism, as expressions separated by commas should share similar form.

BEFORE: Subscribe to events in componentDidMount(), unsubscribe in componentWillUnmount(), and when you receive an event, call setState().
AFTER: Subscribe to events in componentDidMount(), unsubscribe in componentWillUnmount(), and call setState() when you receive an event.

@zpao
Copy link
Member

zpao commented Dec 22, 2014

👍

zpao added a commit that referenced this pull request Dec 22, 2014
Update 14-communicate-between-components.md for grammatical changes
@zpao zpao merged commit 343cda7 into facebook:master Dec 22, 2014
zpao added a commit that referenced this pull request Jan 17, 2015
Update 14-communicate-between-components.md for grammatical changes
zpao added a commit that referenced this pull request Jan 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants