Backport useId tracking fix to React 18
#31668
Conversation
|
@kognise is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @kognise! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
A hydration error occurs when using `useId` with a parent that has a render phase update. This has already been fixed in React 19 by facebook#25713. React 18 will have users for some time, and this issue is showing up in production. Therefore, this backports that fix to React 18. Fixes facebook#31653.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Is there any chance for merge for next |
Fixes #31653.
A hydration error occurs when using
useIdwith a parent that has a render phase update. @gnoff and @sebmarkbage fixed this for React 19 in #25713.React 18 will have users for some time, and we are encountering this issue in production. For these reasons, I think it is a good idea to backport that fix to React 18.
I am definitely not a React contributor nor familiar with its internals, so this may be unwanted or an incorrect solution. I also apologize if I used the wrong base branch for a new release.
Consideration appreciated!