Clean up findFiberByHostInstance from DevTools Hook #31711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 7283a21...be5cf17 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
hoxyq
approved these changes
Dec 10, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
The need for this was removed in #30831 Since the new DevTools version has been released for a while and we expect people to more or less auto-update. Future versions of React don't need this. Once we remove the remaining uses of `getInstanceFromNode` e.g. in the deprecated internal `findDOMNode`/`findNodeHandle` and the event system, we can completely remove the tagging of DOM nodes. DiffTrain build for [3b597c0](3b597c0)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
The need for this was removed in #30831 Since the new DevTools version has been released for a while and we expect people to more or less auto-update. Future versions of React don't need this. Once we remove the remaining uses of `getInstanceFromNode` e.g. in the deprecated internal `findDOMNode`/`findNodeHandle` and the event system, we can completely remove the tagging of DOM nodes. DiffTrain build for [3b597c0](3b597c0)
This was referenced Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The need for this was removed in #30831
Since the new DevTools version has been released for a while and we expect people to more or less auto-update. Future versions of React don't need this.
Once we remove the remaining uses of
getInstanceFromNodee.g. in the deprecated internalfindDOMNode/findNodeHandleand the event system, we can completely remove the tagging of DOM nodes.