Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove consoleManagedByDevToolsDuringStrictMode #31755

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Remove consoleManagedByDevToolsDuringStrictMode #31755

merged 2 commits into from
Dec 13, 2024

Conversation

rickhanlonii
Copy link
Member

This is enabled everywhere except the test renderers, which don't use it.

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 4:01pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 13, 2024
@react-sizebot
Copy link

react-sizebot commented Dec 13, 2024 •
edited
Loading

Comparing: a7b8295...33e1f8c

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.72 kB 510.72 kB = 91.37 kB 91.37 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 515.63 kB 515.63 kB = 92.07 kB 92.07 kB
facebook-www/ReactDOM-prod.classic.js = 595.55 kB 595.55 kB = 105.06 kB 105.06 kB
facebook-www/ReactDOM-prod.modern.js = 585.82 kB 585.82 kB = 103.49 kB 103.49 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.js +0.31% 309.35 kB 310.29 kB +0.28% 54.58 kB 54.73 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.js +0.31% 309.43 kB 310.37 kB +0.27% 54.60 kB 54.75 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.js +0.30% 309.60 kB 310.54 kB +0.27% 54.64 kB 54.79 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js +0.29% 330.93 kB 331.87 kB +0.26% 58.00 kB 58.16 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js +0.27% 352.94 kB 353.88 kB +0.23% 61.09 kB 61.24 kB

Generated by 🚫 dangerJS against e19682e

@rickhanlonii rickhanlonii mentioned this pull request Dec 13, 2024
Merged
sebmarkbage
sebmarkbage reviewed Dec 13, 2024
View reviewed changes
packages/react-reconciler/src/ReactFiberDevToolsHook.js
// suppress warnings and disable scheduler yielding during the double render
unstable_setDisableYieldValue(newIsStrictMode);
setSuppressWarning(newIsStrictMode);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should get rid of this hack at some point. I don't think it was meant to survive the roll out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'll fix that outside this diff now that I branched off it

@hoxyq hoxyq mentioned this pull request Dec 13, 2024
Closed
@rickhanlonii rickhanlonii merged commit 4dff0e6 into facebook:main Dec 13, 2024
187 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@rickhanlonii
Remove consoleManagedByDevToolsDuringStrictMode (#31755)
d5aa92e 
This is enabled everywhere except the test renderers, which don't use
it.

DiffTrain build for [4dff0e6](4dff0e6)
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@rickhanlonii
Remove consoleManagedByDevToolsDuringStrictMode (#31755)
f0381ca 
This is enabled everywhere except the test renderers, which don't use
it.

DiffTrain build for [4dff0e6](4dff0e6)
rickhanlonii added a commit that referenced this pull request Dec 13, 2024
@rickhanlonii
Remove disableIEWorkarounds (#31756)
fb12845 
Based off #31755

This is landed everywhere.
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@rickhanlonii
Remove disableIEWorkarounds (#31756)
9f5fb91 
Based off #31755

This is landed everywhere.

DiffTrain build for [fb12845](fb12845)
github-actions bot pushed a commit that referenced this pull request Dec 13, 2024
@rickhanlonii
Remove disableIEWorkarounds (#31756)
4d3cdac 
Based off #31755

This is landed everywhere.

DiffTrain build for [fb12845](fb12845)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 13, 2024
@pull
Remove disableIEWorkarounds (facebook#31756)
455c5c3 
Based off facebook#31755

This is landed everywhere.

DiffTrain build for [fb12845](facebook@fb12845)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 13, 2024
@pull
Remove disableIEWorkarounds (facebook#31756)
bae10e0 
Based off facebook#31755

This is landed everywhere.

DiffTrain build for [fb12845](facebook@fb12845)
This was referenced Dec 18, 2024
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoxyq hoxyq hoxyq approved these changes

@sebmarkbage sebmarkbage sebmarkbage approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rickhanlonii @react-sizebot @sebmarkbage @hoxyq @facebook-github-bot