Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Validate downloaded build artifact #31847

Merged
merged 2 commits into from
Dec 19, 2024
Merged

[ci] Validate downloaded build artifact #31847

merged 2 commits into from
Dec 19, 2024

Conversation

poteto
Copy link
Member

@poteto poteto commented Dec 19, 2024

Adds validation to download-build-artifacts to confirm that the downloaded artifact matches what was requested.


Stack created with Sapling. Best reviewed with ReviewStack.

This was previously scoped to just commits on `main` but this restriction is unnecessary.
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 0:58am

Adds validation to download-build-artifacts to confirm that the downloaded artifact matches what was requested.
@react-sizebot
Copy link

react-sizebot commented Dec 19, 2024

Comparing: faf6c4d...b663465

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.16% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.71 kB 510.71 kB = 91.29 kB 91.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.16% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 516.86 kB 516.86 kB = 92.24 kB 92.24 kB
facebook-www/ReactDOM-prod.classic.js = 592.42 kB 592.42 kB = 104.37 kB 104.38 kB
facebook-www/ReactDOM-prod.modern.js = 582.68 kB 582.68 kB = 102.82 kB 102.82 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/scheduler/cjs/Scheduler-dev.js +1.63% 11.91 kB 12.11 kB +1.76% 2.61 kB 2.66 kB

Generated by 🚫 dangerJS against db55d43

poteto added a commit that referenced this pull request Dec 19, 2024
This was previously scoped to just commits on `main` but this
restriction is unnecessary.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31846).
* #31848
* #31847
* __->__ #31846
@poteto poteto merged commit 74e39ce into main Dec 19, 2024
365 of 371 checks passed
@poteto poteto deleted the pr31847 branch December 19, 2024 01:09
poteto added a commit that referenced this pull request Dec 19, 2024
This might primarily only affect those using Sapling for React
development, but pushing the same commit to multiple branches shouldn't
cancel the run

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31848).
* __->__ #31848
* #31847
* #31846
github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
Adds validation to download-build-artifacts to confirm that the
downloaded artifact matches what was requested.

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31847).
* #31848
* __->__ #31847
* #31846

DiffTrain build for [74e39ce](74e39ce)
github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
This might primarily only affect those using Sapling for React
development, but pushing the same commit to multiple branches shouldn't
cancel the run

---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31848).
* __->__ #31848
* #31847
* #31846

DiffTrain build for [7de040c](7de040c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants