Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flight] Support streaming of decodeReply in Edge environments #31852

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

sebmarkbage
Copy link
Contributor

We support streaming multipart/form-data in Node.js using Busboy since that's kind of the idiomatic ecosystem way for handling these stream there. There's not really anything idiomatic like that for Edge that's universal yet.

This adds a version that's basically just AsyncIterable.from(formData). It could also be a ReadableStream of those entries since those are also AsyncIterable.

I imagine that in the future we might add one from a binary ReadableStream that does the parsing built-in.

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 4:47am

@react-sizebot
Copy link

Comparing: 7de040c...7260dd0

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.71 kB 510.71 kB = 91.29 kB 91.29 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 516.86 kB 516.86 kB = 92.24 kB 92.24 kB
facebook-www/ReactDOM-prod.classic.js = 592.42 kB 592.42 kB = 104.37 kB 104.37 kB
facebook-www/ReactDOM-prod.modern.js = 582.68 kB 582.68 kB = 102.82 kB 102.82 kB
oss-experimental/react-server-dom-webpack/server.edge.js +10.73% 0.66 kB 0.73 kB +6.32% 0.29 kB 0.30 kB
oss-stable-semver/react-server-dom-webpack/server.edge.js +10.73% 0.66 kB 0.73 kB +6.32% 0.29 kB 0.30 kB
oss-stable/react-server-dom-webpack/server.edge.js +10.73% 0.66 kB 0.73 kB +6.32% 0.29 kB 0.30 kB
oss-experimental/react-server-dom-turbopack/server.edge.js +10.66% 0.67 kB 0.74 kB +6.29% 0.29 kB 0.30 kB
oss-stable-semver/react-server-dom-turbopack/server.edge.js +10.66% 0.67 kB 0.74 kB +6.29% 0.29 kB 0.30 kB
oss-stable/react-server-dom-turbopack/server.edge.js +10.66% 0.67 kB 0.74 kB +6.29% 0.29 kB 0.30 kB
oss-experimental/react-server-dom-parcel/server.edge.js +10.16% 0.70 kB 0.77 kB +5.92% 0.29 kB 0.30 kB
oss-stable-semver/react-server-dom-parcel/server.edge.js +10.16% 0.70 kB 0.77 kB +5.92% 0.29 kB 0.30 kB
oss-stable/react-server-dom-parcel/server.edge.js +10.16% 0.70 kB 0.77 kB +5.92% 0.29 kB 0.30 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-webpack/server.edge.js +10.73% 0.66 kB 0.73 kB +6.32% 0.29 kB 0.30 kB
oss-stable-semver/react-server-dom-webpack/server.edge.js +10.73% 0.66 kB 0.73 kB +6.32% 0.29 kB 0.30 kB
oss-stable/react-server-dom-webpack/server.edge.js +10.73% 0.66 kB 0.73 kB +6.32% 0.29 kB 0.30 kB
oss-experimental/react-server-dom-turbopack/server.edge.js +10.66% 0.67 kB 0.74 kB +6.29% 0.29 kB 0.30 kB
oss-stable-semver/react-server-dom-turbopack/server.edge.js +10.66% 0.67 kB 0.74 kB +6.29% 0.29 kB 0.30 kB
oss-stable/react-server-dom-turbopack/server.edge.js +10.66% 0.67 kB 0.74 kB +6.29% 0.29 kB 0.30 kB
oss-experimental/react-server-dom-parcel/server.edge.js +10.16% 0.70 kB 0.77 kB +5.92% 0.29 kB 0.30 kB
oss-stable-semver/react-server-dom-parcel/server.edge.js +10.16% 0.70 kB 0.77 kB +5.92% 0.29 kB 0.30 kB
oss-stable/react-server-dom-parcel/server.edge.js +10.16% 0.70 kB 0.77 kB +5.92% 0.29 kB 0.30 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js +1.25% 86.31 kB 87.39 kB +1.27% 18.05 kB 18.28 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js +1.25% 86.31 kB 87.39 kB +1.27% 18.05 kB 18.28 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js +1.19% 90.76 kB 91.85 kB +1.20% 18.76 kB 18.98 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js +1.18% 93.57 kB 94.67 kB +1.16% 19.22 kB 19.45 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js +1.18% 93.57 kB 94.67 kB +1.16% 19.22 kB 19.45 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js +1.17% 93.64 kB 94.73 kB +1.16% 19.24 kB 19.46 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js +1.17% 93.64 kB 94.73 kB +1.16% 19.24 kB 19.46 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js +1.12% 98.03 kB 99.13 kB +1.23% 20.00 kB 20.24 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js +1.12% 98.09 kB 99.19 kB +1.22% 20.01 kB 20.25 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js +0.99% 132.24 kB 133.55 kB +1.03% 24.65 kB 24.91 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js +0.99% 132.24 kB 133.55 kB +1.03% 24.65 kB 24.91 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.96% 140.39 kB 141.74 kB +0.97% 26.06 kB 26.31 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.96% 140.39 kB 141.74 kB +0.97% 26.06 kB 26.31 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.96% 140.46 kB 141.81 kB +0.98% 26.07 kB 26.33 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.96% 140.46 kB 141.81 kB +0.98% 26.07 kB 26.33 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js +0.89% 146.75 kB 148.06 kB +0.95% 27.08 kB 27.33 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.87% 154.91 kB 156.25 kB +0.93% 28.49 kB 28.76 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.87% 154.98 kB 156.32 kB +0.93% 28.50 kB 28.77 kB

Generated by 🚫 dangerJS against 9cff93c

@sebmarkbage sebmarkbage merged commit 9f540fc into facebook:main Dec 19, 2024
187 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants