Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off enableYieldingBeforePassive in internal test renderers #31863

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

jackpope
Copy link
Contributor

#31785 turned on enableYieldingBeforePassive for the internal test renderer builds. We have some failing tests on the RN side blocking the sync so lets turn these off for now.

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 11:08pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 19, 2024
@jackpope jackpope changed the title Turn off enableYeildingBeforePassive in internal test renderers Turn off enableYieldingBeforePassive in internal test renderers Dec 19, 2024
@react-sizebot
Copy link

Comparing: 518d06d...beb528a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 511.38 kB 511.38 kB = 91.38 kB 91.38 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 516.17 kB 516.17 kB = 92.23 kB 92.23 kB
facebook-www/ReactDOM-prod.classic.js = 593.09 kB 593.09 kB = 104.45 kB 104.45 kB
facebook-www/ReactDOM-prod.modern.js = 583.35 kB 583.35 kB = 102.90 kB 102.90 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 30803b9

Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures may be caused by missing an act(). Though these should ideally all already be accompanied by missing act() warnings.

@jackpope jackpope merged commit de82912 into facebook:main Dec 20, 2024
187 checks passed
@jackpope jackpope deleted the disable-yield-before-passive branch December 20, 2024 14:48
@jackpope
Copy link
Contributor Author

@eps1lon We can work through the test failures, its definitely possible there are setup or act problems. But we need to prioritize catching up the sync before the holidays. Then we can test turning these back on.

github-actions bot pushed a commit that referenced this pull request Dec 20, 2024
#31785 turned on
`enableYieldingBeforePassive` for the internal test renderer builds. We
have some failing tests on the RN side blocking the sync so lets turn
these off for now.

DiffTrain build for [de82912](de82912)
github-actions bot pushed a commit that referenced this pull request Dec 20, 2024
#31785 turned on
`enableYieldingBeforePassive` for the internal test renderer builds. We
have some failing tests on the RN side blocking the sync so lets turn
these off for now.

DiffTrain build for [de82912](de82912)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants