-
Notifications
You must be signed in to change notification settings - Fork 47.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn off enableYieldingBeforePassive in internal test renderers #31863
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comparing: 518d06d...beb528a Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failures may be caused by missing an act()
. Though these should ideally all already be accompanied by missing act() warnings.
@eps1lon We can work through the test failures, its definitely possible there are setup or act problems. But we need to prioritize catching up the sync before the holidays. Then we can test turning these back on. |
#31785 turned on
enableYieldingBeforePassive
for the internal test renderer builds. We have some failing tests on the RN side blocking the sync so lets turn these off for now.