Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maintainer check condition #32110

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Fix maintainer check condition #32110

merged 1 commit into from
Jan 17, 2025

Conversation

damianstasik
Copy link
Contributor

Summary

I've noticed that the value stored under is_core_team gets stringified, so some PRs may be mislabelled as coming from the core team.

I've checked this on my fork and saw stringified null returned by the is_core_team, and this PR explicitly checks for the correct value. Feel free to close this PR if you want to go with another approach.

How did you test this change?

Checked this change on my fork with and without listing myself in the maintainers file.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@react-sizebot
Copy link

Comparing: 61e713c...bb496f1

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 514.24 kB 514.24 kB = 91.73 kB 91.73 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 556.18 kB 556.18 kB = 98.72 kB 98.72 kB
facebook-www/ReactDOM-prod.classic.js = 595.79 kB 595.79 kB = 104.85 kB 104.85 kB
facebook-www/ReactDOM-prod.modern.js = 586.21 kB 586.21 kB = 103.30 kB 103.30 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against cac72e2

@poteto poteto removed the React Core Team Opened by a member of the React Core Team label Jan 17, 2025
@poteto
Copy link
Member

poteto commented Jan 17, 2025

Oof thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants