Fix maintainer check condition #32110
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I've noticed that the value stored under
is_core_team
gets stringified, so some PRs may be mislabelled as coming from the core team.I've checked this on my fork and saw stringified
null
returned by theis_core_team
, and this PR explicitly checks for the correct value. Feel free to close this PR if you want to go with another approach.How did you test this change?
Checked this change on my fork with and without listing myself in the maintainers file.