-
Notifications
You must be signed in to change notification settings - Fork 47.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 12-context.md #5923
Update 12-context.md #5923
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
@@ -160,6 +160,35 @@ function Button(props, context) { | |||
Button.contextTypes = {color: React.PropTypes.string}; | |||
``` | |||
|
|||
## How to context updates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just make this 'Updating context'
Thanks for the feedback. I've updated the file with your comments. |
@puppybits updated the pull request. |
Thanks! Could you squash into a single commit? |
Context was missing info on how to update the context after the initial render. Added a simple blurb and an example. [Docs] 12-context.md code review changes
squashed. |
Thanks! |
Update 12-context.md (cherry picked from commit 9c3f595)
Context was missing info on how to update the context after the initial render. Added a simple blurb and an example.