Build with babel-preset-fbjs #6876
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ghost
added
| src, | ||
| Object.assign( | ||
| {filename: path.relative(process.cwd(), filePath)}, | ||
| babelOptions | ||
| ) | ||
| ).code; | ||
| if (/ReactElementValidator\-test/.test(filePath)) | ||
| console.log(code); |
There was a problem hiding this comment.
oooooops, this is how I try to debug to see if the transform did something weird. This would obviously go away.
2 tasks
|
@zpao do we still want to do this? |
|
Meh. Probably not a bad idea but I don't think I'm going to come back to it. Closing out but feel free to reboot the effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Update our build to use
babel-preset-fbjs. A couple tests appear to be failing so I still need to look into that. It looks like the only difference in build files is that the preset adds the function names, otherwise I think we're identical (full diff: https://gist.github.com/zpao/7a8dc9613d9e047d680f7b1708d5368a)