Configured prettier #308
Open
Configured prettier #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
Aug 2, 2017
| @@ -23,9 +23,10 @@ | |||
| "url": "git://github.com/facebook/regenerator.git" | |||
| }, | |||
| "main": "main.js", | |||
| "bin": "bin/regenerator", | |||
| "bin": "bin/regenerator.js", | |||
There was a problem hiding this comment.
ive changed it so this file could also be 'caught' by the lint-staged's *.js rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ive noticed in the other PR that there was some mismatch between PR code style and the desired style of the repo. This was also a slight problem for me when making changes as there were no linting rules around to help me and I had double check semicolon, quotes style etc - especially as I couldnt focus at one moment and was coming back to work several times when only I had some time.
This should help the situation - I've gone with the pure prettier as its super easy to add for the project and doesnt require too much configuration with its 'take it or leave it' approach.
Note: I would advice to merge this locally and run prettier on the whole project once - both to see the difference and judge if you like it or not and to commit the changes if liked.