Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mononoke/integration tests: handle case-sensitive related tests #49

Closed
wants to merge 1 commit into from
Closed

mononoke/integration tests: handle case-sensitive related tests #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions eden/mononoke/tests/integration/run_tests_getdeps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
from glob import iglob
from os.path import abspath, basename, dirname, join
from pathlib import Path
from sys import platform


parser = argparse.ArgumentParser(
Expand Down Expand Up @@ -73,7 +74,6 @@
excluded_tests = {
"test-backsync-forever.t", # Unknown issue
"test-blobimport-lfs.t", # Timed out
"test-blobimport.t", # Case insensitivity of paths in MacOS
"test-bookmarks-filler.t", # Probably missing binary
"test-cmd-manual-scrub.t", # Just wrong outout
"test-edenapi-server-commit-location-to-hash.t", # Missing eden/scm's commands
Expand Down Expand Up @@ -108,7 +108,6 @@
"test-mononoke-hg-sync-job-generate-bundles-lfs-verification.t", # Timed out
"test-mononoke-hg-sync-job-generate-bundles-lfs.t", # Timed out
"test-push-protocol-lfs.t", # Timed out
"test-pushrebase-block-casefolding.t", # Most likely MacOS path case insensitivity
"test-remotefilelog-lfs.t", # Timed out
"test-scs-blame.t", # Missing SCS_SERVER
"test-scs-common-base.t", # Missing SCS_SERVER
Expand All @@ -124,6 +123,11 @@
"test-unbundle-replay-hg-recording.t", # Returns different data in OSS
}

if platform == "darwin":
excluded_tests.update(
{"test-pushrebase-block-casefolding.t"} # MacOS is path case insensitive
)

tests = [
t
for t in (
Expand Down
4 changes: 2 additions & 2 deletions eden/mononoke/tests/integration/test-blobimport.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@

# Capitals and underscores in a filename. Total len of the filename is 253
# 253 because: 253 + len(".i") = 255 (max filename in UNIX system)
$ UNDERSCORES=`printf '_%.0s' {1..123}`
$ CAPITALS=`printf 'A%.0s' {1..130}`
$ UNDERSCORES=`printf '_%.0s' {1..122}`
$ CAPITALS=`printf 'A%.0s' {1..131}`
$ echo s > "$UNDERSCORES$CAPITALS"
$ hg commit -Aqm "underscores, capitals"

Expand Down