Skip to content

Commit

Permalink
tests/integration/modified.php
Browse files Browse the repository at this point in the history 
Summary: A failing (on OSX) test case as evidence that the current OSX implementation doesn't notice file changes.

Test Plan:
unit test

Here is the full unit test suite output (`make integration`) - this new test is not the only one failing on OSX. They all also failed before this test, except that this test seems to trigger a failure in the trigger test that isn't there before (some kind of teardown necessary?). Pun intended.

  arc unit --everything
  /Users/fugalh/src/phab/arcanist/bin/arc
  [2013-10-26 19:34:42] ERROR 8: Undefined index: files at [/Users/fugalh/src/watchman/tests/integration/pcre.php:19]
    #0 pcreTestCase::testPCRE()
    #1 call_user_func_array(Array of size 2 starting with: { 0 => Object pcreTestCase }, Array ) called at [/Users/fugalh/src/phab/arcanist/src/unit/engine/phutil/ArcanistPhutilTestCase.php:445]
    #2 ArcanistPhutilTestCase::run() called at [/Users/fugalh/src/watchman/arcanist/lib/WatchmanIntegrationEngine.php:68]
    #3 WatchmanIntegrationEngine::runIntegrationTests() called at [/Users/fugalh/src/watchman/arcanist/lib/WatchmanIntegrationEngine.php:10]
    #4 WatchmanIntegrationEngine::run() called at [/Users/fugalh/src/phab/arcanist/src/workflow/ArcanistUnitWorkflow.php:173]
    #5 ArcanistUnitWorkflow::run() called at [/Users/fugalh/src/phab/arcanist/scripts/arcanist.php:318]
  [2013-10-26 19:34:42] ERROR 8: Undefined index: files at [/Users/fugalh/src/watchman/tests/integration/pcre.php:19]
    #0 pcreTestCase::testPCRE()
    #1 call_user_func_array(Array of size 2 starting with: { 0 => Object pcreTestCase }, Array ) called at [/Users/fugalh/src/phab/arcanist/src/unit/engine/phutil/ArcanistPhutilTestCase.php:445]
    #2 ArcanistPhutilTestCase::run() called at [/Users/fugalh/src/watchman/arcanist/lib/WatchmanIntegrationEngine.php:73]
    #3 WatchmanIntegrationEngine::runIntegrationTests() called at [/Users/fugalh/src/watchman/arcanist/lib/WatchmanIntegrationEngine.php:10]
    #4 WatchmanIntegrationEngine::run() called at [/Users/fugalh/src/phab/arcanist/src/workflow/ArcanistUnitWorkflow.php:173]
    #5 ArcanistUnitWorkflow::run() called at [/Users/fugalh/src/phab/arcanist/scripts/arcanist.php:318]
  [2013-10-26 19:34:43] ERROR 8: Undefined index: files at [/Users/fugalh/src/watchman/tests/integration/pcre.php:19]
    #0 pcreTestCase::testPCRE()
    #1 call_user_func_array(Array of size 2 starting with: { 0 => Object pcreTestCase }, Array ) called at [/Users/fugalh/src/phab/arcanist/src/unit/engine/phutil/ArcanistPhutilTestCase.php:445]
    #2 ArcanistPhutilTestCase::run() called at [/Users/fugalh/src/watchman/arcanist/lib/WatchmanIntegrationEngine.php:73]
    #3 WatchmanIntegrationEngine::runIntegrationTests() called at [/Users/fugalh/src/watchman/arcanist/lib/WatchmanIntegrationEngine.php:10]
    #4 WatchmanIntegrationEngine::run() called at [/Users/fugalh/src/phab/arcanist/src/workflow/ArcanistUnitWorkflow.php:173]
    #5 ArcanistUnitWorkflow::run() called at [/Users/fugalh/src/phab/arcanist/scripts/arcanist.php:318]
     PASS   <1ms★  argv.t
     PASS    1ms★  bser.t
     PASS   <1ms★  log.t
     FAIL  testBigPCRE
  Assertion failed at line 48 in bigpcre.php: got useful message: failed to parse query: unknown expression term 'pcre'
  Expected: true
    Actual: false
     FAIL  testBigPCRE [CLI: bser/json]
  Assertion failed at line 48 in bigpcre.php: got useful message: failed to parse query: unknown expression term 'pcre'
  Expected: true
    Actual: false
     FAIL  testBigPCRE [CLI: json/json]
  Assertion failed at line 48 in bigpcre.php: got useful message: failed to parse query: unknown expression term 'pcre'
  Expected: true
    Actual: false
     PASS    7ms★  testBSDishTopLevel
     PASS   34ms★  testBSDishTopLevel [CLI: bser/json]
     PASS   35ms★  testBSDishTopLevel [CLI: json/json]
     PASS    2ms★  testClock
     PASS   12ms★  testClock [CLI: bser/json]
     PASS   13ms★  testClock [CLI: json/json]
     PASS    8ms★  testCursor
     PASS   74ms   testCursor [CLI: bser/json]
     PASS   73ms   testCursor [CLI: json/json]
     PASS    5ms★  testEmpty
     PASS   33ms★  testEmpty [CLI: bser/json]
     PASS   34ms★  testEmpty [CLI: json/json]
     PASS    4ms★  testFields
     PASS   21ms★  testFields [CLI: bser/json]
     PASS   22ms★  testFields [CLI: json/json]
     PASS   10ms★  testFind
     PASS   26ms★  testFind [CLI: bser/json]
     PASS   25ms★  testFind [CLI: json/json]
     PASS   16ms★  testFishy
     PASS    3ms★  testIgnoreGit
     PASS    9ms★  testIgnoreGit [CLI: bser/json]
     PASS    9ms★  testIgnoreGit [CLI: json/json]
     PASS   <1ms★  testSockName
     PASS    6ms★  testSockName [CLI: bser/json]
     PASS    6ms★  testSockName [CLI: json/json]
     PASS    3ms★  testInvalidSyncTimeout
     PASS    1ms★  testInvalidExprTerm
     PASS   19ms★  testInvalidSyncTimeout [CLI: bser/json]
     PASS   13ms★  testInvalidExprTerm [CLI: bser/json]
     PASS   13ms★  testInvalidExprTerm [CLI: json/json]
     PASS   19ms★  testInvalidSyncTimeout [CLI: json/json]
     PASS   <1ms★  testInvalidRoot
     PASS    6ms★  testInvalidRoot [CLI: bser/json]
     PASS    6ms★  testInvalidRoot [CLI: json/json]
     FAIL  testModify
  Assertion failed at line 27 in modified.php
  Expected vs Actual Output Diff
  --- Old Value
  +++ New Value
  @@ -1,5 +1 @@
  -Array
  -(
  -    [0] => foo/111
  -)
  -
  +null

     PASS   40ms★  testEvenMoreMoves
     PASS   27ms★  testMoreMoves
     PASS   44ms★  testMoreMoves [CLI: bser/json]
     PASS   57ms   testEvenMoreMoves [CLI: bser/json]
     PASS   57ms   testEvenMoreMoves [CLI: json/json]
     PASS   44ms★  testMoreMoves [CLI: json/json]
     PASS    9ms★  testMoveReAdd
     PASS   83ms   testMoveReAdd [CLI: bser/json]
     PASS   82ms   testMoveReAdd [CLI: json/json]
     PASS    7ms★  testNameExpr
     PASS   79ms   testNameExpr [CLI: bser/json]
     PASS   82ms   testNameExpr [CLI: json/json]
     PASS    5ms★  testOtherCookies
     PASS   11ms★  testOtherCookies [CLI: bser/json]
     PASS   10ms★  testOtherCookies [CLI: json/json]
     FAIL  testPCRE
  Assertion failed at line 19 in pcre.php
  Expected: foo.c
    Actual: null
     FAIL  testPCRE [CLI: bser/json]
  Assertion failed at line 19 in pcre.php
  Expected: foo.c
    Actual: null
     FAIL  testPCRE [CLI: json/json]
  Assertion failed at line 19 in pcre.php
  Expected: foo.c
    Actual: null
     PASS   20ms★  testRemove
     PASS   43ms★  testRemove [CLI: bser/json]
     PASS   41ms★  testRemove [CLI: json/json]
     PASS    4ms★  testRemoveRoot
     PASS   10ms★  testRemoveRoot [CLI: bser/json]
     PASS    9ms★  testRemoveRoot [CLI: json/json]
     PASS   20ms★  testRootRestrict
     PASS   62ms   testRootRestrict [CLI: bser/json]
     PASS   61ms   testRootRestrict [CLI: json/json]
     PASS    8ms★  testSinceExpr
     PASS   64ms   testSinceExpr [CLI: bser/json]
     PASS   64ms   testSinceExpr [CLI: json/json]
     PASS    6ms★  testSinceIssue2
     PASS    4ms★  testRecrawlFreshInstance
     PASS    8ms★  testSinceFreshInstance
     PASS    5ms★  testReaddWatchFreshInstance
     PASS    6ms★  testSinceIssue1
     PASS   64ms   testSinceFreshInstance [CLI: bser/json]
     PASS   23ms★  testSinceIssue1 [CLI: bser/json]
     PASS   27ms★  testRecrawlFreshInstance [CLI: bser/json]
     PASS   33ms★  testReaddWatchFreshInstance [CLI: bser/json]
     PASS   59ms   testSinceIssue2 [CLI: bser/json]
     PASS   28ms★  testRecrawlFreshInstance [CLI: json/json]
     PASS   57ms   testSinceIssue2 [CLI: json/json]
     PASS   64ms   testSinceFreshInstance [CLI: json/json]
     PASS   34ms★  testReaddWatchFreshInstance [CLI: json/json]
     PASS   22ms★  testSinceIssue1 [CLI: json/json]
     PASS  210ms   testSubscribe
     PASS    6ms★  testSuffixExpr
     PASS   23ms★  testSuffixExpr [CLI: bser/json]
     PASS   20ms★  testSuffixExpr [CLI: json/json]
     FAIL  testTrigger
  EXCEPTION (Exception): expected a log response, got {"version":"2.8.2","clock":"c:1382816076:60845:86:4","since":"c:1382816076:60845:82:1","is_fresh_instance":true,"files":["bar.txt","foo.c"],"subscription":"test","root":"/private/var/folders/j1/y_xh789x5mj2dgc_k76mtl_r47sbp0/T/2646poi2hjlwcgc0"}

  #0 /Users/fugalh/src/watchman/arcanist/lib/WatchmanTestCase.php(126): WatchmanInstance->waitForLog('/posix_spawnp/', 60)
  #1 /Users/fugalh/src/watchman/arcanist/lib/WatchmanTestCase.php(130): WatchmanTestCase->waitForLog('/posix_spawnp/', 60)
  #2 /Users/fugalh/src/watchman/tests/integration/trigger.php(86): WatchmanTestCase->assertWaitForLog('/posix_spawnp/', 60)
  #3 [internal function]: triggerTestCase->testTrigger()
  #4 /Users/fugalh/src/phab/arcanist/src/unit/engine/phutil/ArcanistPhutilTestCase.php(445): call_user_func_array(Array, Array)
  #5 /Users/fugalh/src/watchman/arcanist/lib/WatchmanIntegrationEngine.php(68): ArcanistPhutilTestCase->run()
  #6 /Users/fugalh/src/watchman/arcanist/lib/WatchmanIntegrationEngine.php(10): WatchmanIntegrationEngine->runIntegrationTests()
  #7 /Users/fugalh/src/phab/arcanist/src/workflow/ArcanistUnitWorkflow.php(173): WatchmanIntegrationEngine->run()
  #8 /Users/fugalh/src/phab/arcanist/scripts/arcanist.php(318): ArcanistUnitWorkflow->run()
  #9 {main}
     PASS   1.0s   testTwoDeep
     PASS   1.1s   testTwoDeep [CLI: bser/json]
     PASS   1.0s   testTwoDeep [CLI: json/json]
     PASS    4ms★  testTypeExpr
     PASS   33ms★  testTypeExpr [CLI: bser/json]
     PASS   31ms★  testTypeExpr [CLI: json/json]
  make: *** [integration] Error 2

Reviewers: wez, sid0

CC: net-systems@

Differential Revision: https://phabricator.fb.com/D1029383
  • Loading branch information
@fugalh @wez
fugalh authored and wez committed Oct 28, 2013
1 parent 947f74c commit 9bee3b9
Showing 1 changed file with 31 additions and 0 deletions.
31 changes: 31 additions & 0 deletions tests/integration/modified.php
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<?php
/* Copyright 2013-present Facebook, Inc.
* Licensed under the Apache License, Version 2.0 */

class modifyTest extends WatchmanTestCase {
function needsLiveConnection() {
return true;
}

function testModify() {
$dir = PhutilDirectoryFixture::newEmptyFixture();
$root = realpath($dir->getPath());

mkdir("$root/foo");
touch("$root/foo/111");
$watch = $this->watch($root);
$this->watchmanCommand('subscribe', $root, 'test',
array('fields' => array('name')));
$this->waitForSub('test', function($data) { return true; });
$this->getSubData('test');

$this->watchmanCommand('log', 'error', 'XXX: touch foo/111');
touch("$root/foo/111");

$this->waitForSub('test', function($data) { return true; });
list($sub) = $this->getSubData('test');
$this->assertEqual(array("foo/111"), $sub['files']);

$this->watchmanCommand('unsubscribe', $root, 'test');
}
}

0 comments on commit 9bee3b9

Please sign in to comment.