Don't transfer layout outputs to java if they didn't change #483
Comments
|
Is this the issue for the reverted commit of b283572 @emilsjolander ? Just trying to track progress waiting for an update in order to be able to ship a release. |
|
Not exactly. But it is part of it. Reverted commit will reland this week. |
|
Thanks for the info @emilsjolander ! Tracking commits into master as well then :) |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this issue
Apr 1, 2017
Summary: See facebook/yoga#483. We should not transfer the layout if the layout didn't change. (using ```hasNewLayout```). This also changes that the lock on the java node is only aquired if needed, and it holds the lock only for the time the values are set and not for the time all it's children are set. Closes facebook/yoga#484 Reviewed By: astreet Differential Revision: D4802966 Pulled By: emilsjolander fbshipit-source-id: e8a8f2280ad6b25b98fc68b07eac68e0ec80fe3e
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this issue
Apr 1, 2017
Summary: See facebook/yoga#483. We should not transfer the layout if the layout didn't change. (using ```hasNewLayout```). This also changes that the lock on the java node is only aquired if needed, and it holds the lock only for the time the values are set and not for the time all it's children are set. Closes facebook/yoga#484 Reviewed By: astreet Differential Revision: D4802966 Pulled By: emilsjolander fbshipit-source-id: e8a8f2280ad6b25b98fc68b07eac68e0ec80fe3e
facebook-github-bot
pushed a commit
that referenced
this issue
Apr 1, 2017
Summary: See #483. We should not transfer the layout if the layout didn't change. (using ```hasNewLayout```). This also changes that the lock on the java node is only aquired if needed, and it holds the lock only for the time the values are set and not for the time all it's children are set. Closes #484 Reviewed By: astreet Differential Revision: D4802966 Pulled By: emilsjolander fbshipit-source-id: e8a8f2280ad6b25b98fc68b07eac68e0ec80fe3e
grabbou
pushed a commit
to facebook/react-native
that referenced
this issue
Apr 6, 2017
Summary: See facebook/yoga#483. We should not transfer the layout if the layout didn't change. (using ```hasNewLayout```). This also changes that the lock on the java node is only aquired if needed, and it holds the lock only for the time the values are set and not for the time all it's children are set. Closes facebook/yoga#484 Reviewed By: astreet Differential Revision: D4802966 Pulled By: emilsjolander fbshipit-source-id: e8a8f2280ad6b25b98fc68b07eac68e0ec80fe3e
thotegowda
pushed a commit
to thotegowda/react-native
that referenced
this issue
May 7, 2017
Summary: See facebook/yoga#483. We should not transfer the layout if the layout didn't change. (using ```hasNewLayout```). This also changes that the lock on the java node is only aquired if needed, and it holds the lock only for the time the values are set and not for the time all it's children are set. Closes facebook/yoga#484 Reviewed By: astreet Differential Revision: D4802966 Pulled By: emilsjolander fbshipit-source-id: e8a8f2280ad6b25b98fc68b07eac68e0ec80fe3e
|
Implemented. See #484 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When setting layout outputs on a node also set a flag indicating if the layout changed. Read this flag before transferring outputs to java. JNI calls are very expensive so the less of them we need to do the better. Possibly re-use the hasNewLayout flag.
The text was updated successfully, but these errors were encountered: