Don't transfer layout outputs to java for nodes which don't have a new layout #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woehrl01
changed the title
|
@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
java/com/facebook/yoga/YogaNode.java
Outdated
| @@ -81,6 +81,8 @@ public static void setLogger(YogaLogger logger) { | |||
| private float mBorderBottom = 0; | |||
| @DoNotStrip | |||
| private int mLayoutDirection = 0; | |||
| @DoNotStrip | |||
| private bool mHasNewLayout = true; | |||
|
I don't think your last diff is needed. Can you give an example where it would break without it? |
|
@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 29, 2017
…w layout Summary: As suggested in facebook/yoga#484. This is the PR which only adds the part of using a local bool field for storing the hasLayoutFlag, to be able to pass the layout only if it has really changed. Closes facebook/yoga#492 Reviewed By: astreet Differential Revision: D4786961 Pulled By: emilsjolander fbshipit-source-id: cf3d354b93f6dcc3ef817ef73a47bd29e37d1848
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Mar 29, 2017
…w layout Summary: As suggested in facebook/yoga#484. This is the PR which only adds the part of using a local bool field for storing the hasLayoutFlag, to be able to pass the layout only if it has really changed. Closes facebook/yoga#492 Reviewed By: astreet Differential Revision: D4786961 Pulled By: emilsjolander fbshipit-source-id: cf3d354b93f6dcc3ef817ef73a47bd29e37d1848
woehrl01
added a commit
to woehrl01/yoga
that referenced
this pull request
Mar 30, 2017
…w layout Summary: As suggested in facebook#484. This is the PR which only adds the part of using a local bool field for storing the hasLayoutFlag, to be able to pass the layout only if it has really changed. Closes facebook#492 Reviewed By: astreet Differential Revision: D4786961 Pulled By: emilsjolander fbshipit-source-id: cf3d354b93f6dcc3ef817ef73a47bd29e37d1848 fail fast if ygnode gets GCed added backing field for new layout fix compile set padding, margin and border only if set changed from bool to int to reduce jni calls by 2 code review
woehrl01
added a commit
to woehrl01/yoga
that referenced
this pull request
Mar 30, 2017
…w layout Summary: As suggested in facebook#484. This is the PR which only adds the part of using a local bool field for storing the hasLayoutFlag, to be able to pass the layout only if it has really changed. Closes facebook#492 Reviewed By: astreet Differential Revision: D4786961 Pulled By: emilsjolander fbshipit-source-id: cf3d354b93f6dcc3ef817ef73a47bd29e37d1848 fail fast if ygnode gets GCed added backing field for new layout fix compile set padding, margin and border only if set changed from bool to int to reduce jni calls by 2 code review
grabbou
pushed a commit
to facebook/react-native
that referenced
this pull request
Apr 6, 2017
…w layout Summary: As suggested in facebook/yoga#484. This is the PR which only adds the part of using a local bool field for storing the hasLayoutFlag, to be able to pass the layout only if it has really changed. Closes facebook/yoga#492 Reviewed By: astreet Differential Revision: D4786961 Pulled By: emilsjolander fbshipit-source-id: cf3d354b93f6dcc3ef817ef73a47bd29e37d1848
thotegowda
pushed a commit
to thotegowda/react-native
that referenced
this pull request
May 7, 2017
…w layout Summary: As suggested in facebook/yoga#484. This is the PR which only adds the part of using a local bool field for storing the hasLayoutFlag, to be able to pass the layout only if it has really changed. Closes facebook/yoga#492 Reviewed By: astreet Differential Revision: D4786961 Pulled By: emilsjolander fbshipit-source-id: cf3d354b93f6dcc3ef817ef73a47bd29e37d1848
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #484. This is the PR which only adds the part of using a local bool field for storing the hasLayoutFlag, to be able to pass the layout only if it has really changed.