Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new typos found by codespell #4068

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Fix new typos found by codespell #4068

merged 2 commits into from
Jun 29, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

@spaette
Copy link

spaette commented Jun 19, 2024

prettify
skippable

$ grep -n pretify zstd/lib/decompress/zstd_decompress_block.c
361: * - pretify output, report below, test with fuzzer to ensure it's correct */
$ grep -n skippeable zstd/lib/decompress/zstd_decompress.c
814: *  `src` must point to the start of a ZSTD frame or a skippeable frame
$ 

DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Jun 19, 2024
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Jun 19, 2024
@Cyan4973 Cyan4973 self-assigned this Jun 19, 2024
@spaette
Copy link

spaette commented Jun 20, 2024

@Cyan4973

would like to add a few more changes with your approval

$ grep -n "GNUC compatible" zstd/lib/common/portability_macros.h
93: * Only enable assembly for GNUC compatible compilers,
$ grep -nr casted zstd
zstd/lib/compress/zstd_compress.c:2609:    assert(size < (1U<<31));   /* can be casted to int */
$ grep -nr compiation zstd
zstd/build/cmake/CMakeModules/AddZstdCompilationFlags.cmake:60:        # EnableCompilerFlag("-std=c99" true false)   # Set C compiation to c99 standard
$ grep -nr ditionary zstd
zstd/CHANGELOG:492:fix : bug #944 : multithreading with shared ditionary and large data, reported by @gsliepen
$ grep -nr relevants zstd
zstd/lib/compress/zstd_compress.c:5625: *            into its relevants cParams.
$ grep -nr trigging zstd
zstd/lib/common/compiler.h:329: * Helper function to perform a wrapped pointer difference without trigging
$ 

fixes for above

sed -i "s/GNUC compatible/GNU C compatible/g" zstd/lib/common/portability_macros.h
sed -i "s/casted/cast/g" zstd/lib/compress/zstd_compress.c
sed -i "s/compiation/compilation/g" zstd/build/cmake/CMakeModules/AddZstdCompilationFlags.cmake
sed -i "s/ditionary/dictionary/g" zstd/CHANGELOG
sed -i "s/relevants/relevant/g" zstd/lib/compress/zstd_compress.c
sed -i "s/trigging/triggering/g" zstd/lib/common/compiler.h

@DimitriPapadopoulos

for the record approximatively appears in the Oxford dictionary

easier to read however with your change of that string

@Cyan4973
Copy link
Contributor

@spaette
These suggestions look good to me

DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Jun 20, 2024
@DimitriPapadopoulos
Copy link
Contributor Author

Indeed approximatively appears in the OED. It is missing from other mainstream curated dictionaries, and perhaps more importantly (?) is missing from SCOWLS (and friends) which I see as the reference dictionary for open source spell checking.

DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Jun 20, 2024
@DimitriPapadopoulos
Copy link
Contributor Author

I have added all your suggestions.

DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Jun 20, 2024
@spaette
Copy link

spaette commented Jun 29, 2024

the .c, .h, and .cmake files' changes are limited to comments which shouldn't account for the 2 failed checks

@Cyan4973 Cyan4973 merged commit 4fe0ba0 into facebook:dev Jun 29, 2024
91 of 93 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell branch June 30, 2024 12:43
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Sep 1, 2024
DimitriPapadopoulos added a commit to codespell-project/codespell that referenced this pull request Sep 2, 2024
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Sep 8, 2024
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Sep 9, 2024
DimitriPapadopoulos added a commit to DimitriPapadopoulos/codespell that referenced this pull request Sep 9, 2024
DimitriPapadopoulos added a commit to codespell-project/codespell that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants