Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Fixes bug with character removal around entities #1094

Conversation

flarnie
Copy link
Contributor

@flarnie flarnie commented Mar 24, 2017

Fixes #1093

Credit goes 100% to @mmmoussa for finding and fixing this bug, I'm just
making the PR to update Github.

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure that:
  • The test suite passes (npm test)
  • Your code lints (npm run lint) and passes Flow (npm run flow)
  • You have followed the testing guidelines
  1. If you haven't already, complete the CLA.

Please use the simple form below as a guideline for describing your pull request.

Thanks for contributing to Draft.js!

Summary

[...]

Test Plan

[...]

Fixes facebookarchive#1093

Credit goes 100% to @mmmoussa for finding and fixing this bug, I'm just
making the PR to update Github.
@flarnie
Copy link
Contributor Author

flarnie commented Mar 24, 2017

Interestingly this revealed some issues with an earlier PR. Closing this for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when deleting character before an entity on master branch
2 participants