allow for React 16 as peerDependency #1385
Conversation
|
Appart from the |
|
Thanks for adding this! 🎉🎊🍰 The tests ran successfully for me locally, so hopefully that failed CI test run was just a fluke. Restarted the tests, and assuming we can get those passing then I'll be happy to merge this. |
|
yay 🎉 |
|
Hmm - I still don't get those test failures. It looks like you rebased, but I might try rebasing again because those failures are almost certainly not related to the React dependency bump. |
|
Tests continue to pass for me locally, even after |
|
@flarnie weird, especially since it complains also the same changes with master merged into the branch went flawlessly, see: https://travis-ci.org/facebook/draft-js/builds/278655176 |
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
2 similar comments
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Internally I keep getting the message "This seems to be a transient issue. Retry your job, and it will likely pass ." but retrying does not help... Maybe it will be fixed on Monday. |
|
I still get warning I think it means that you need to update package.json from to |
|
I think even better would be to move Would you like to submit a PR? Or I can do it sometime tomorrow. |
|
@flarnie I'm ok with someone else doing this :) it seems like this is just a warning and it still work for now :) |
**what is the change?:** see title **why make this change?:** This was mistakenly added to regular dependencies, when we only use it for testing. **test plan:** `rm -rf node_modules && yarn install && yarn build && yarn test` **issue:** None open yet, but thanks for @JLarky whose comment on facebookarchive#1385 (comment) prompted this.
Summary: **what is the change?:** see title **why make this change?:** This was mistakenly added to regular dependencies, when we only use it for testing. **test plan:** `rm -rf node_modules && yarn install && yarn build && yarn test` **issue:** None open yet, but thanks for JLarky whose comment on #1385 (comment) prompted this. Closes #1415 Differential Revision: D5961436 fbshipit-source-id: bb9c22bf9f29a7cfaea70d2b869b2fb17f31db8c
Summary: **Summary** As Sophie suggested adding React 16 RC helps to avoid peerDep warnings. see https://twitter.com/sophiebits/status/906661088472813568 Closes facebookarchive/draft-js#1385 Differential Revision: D5898819 fbshipit-source-id: 56dc61046d9fc5af1074af8eda7c45b57923573d
Summary: **what is the change?:** see title **why make this change?:** This was mistakenly added to regular dependencies, when we only use it for testing. **test plan:** `rm -rf node_modules && yarn install && yarn build && yarn test` **issue:** None open yet, but thanks for JLarky whose comment on facebookarchive/draft-js#1385 (comment) prompted this. Closes facebookarchive/draft-js#1415 Differential Revision: D5961436 fbshipit-source-id: bb9c22bf9f29a7cfaea70d2b869b2fb17f31db8c
Summary: **Summary** As Sophie suggested adding React 16 RC helps to avoid peerDep warnings. see https://twitter.com/sophiebits/status/906661088472813568 Closes facebookarchive/draft-js#1385 Differential Revision: D5898819 fbshipit-source-id: 56dc61046d9fc5af1074af8eda7c45b57923573d
Summary: **Summary** As Sophie suggested adding React 16 RC helps to avoid peerDep warnings. see https://twitter.com/sophiebits/status/906661088472813568 Closes facebookarchive/draft-js#1385 Differential Revision: D5898819 fbshipit-source-id: 56dc61046d9fc5af1074af8eda7c45b57923573d
Summary
As Sophie suggested adding React 16 RC helps to avoid peerDep warnings. see https://twitter.com/sophiebits/status/906661088472813568