Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

fix(lint): removes unnecessary Boolean cast #2290

Closed
wants to merge 1 commit into from
Closed

fix(lint): removes unnecessary Boolean cast #2290

wants to merge 1 commit into from
+3 −3

Conversation

claudiopro
Copy link
Contributor

Summary

Removes an unnecessary cast to Boolean 

→ yarn lint
Using globally installed version of Yarn
yarn run v1.12.1
$ eslint .

/Users/procidac/Development/gh/claudiopro/draft-js/src/component/handlers/edit/editOnBlur.js
  32:6  warning  Redundant Boolean call  no-extra-boolean-cast

Test Plan

yarn lint

Verify the warning is not printed anymore

facebook-github-bot
facebook-github-bot reviewed Dec 26, 2019
View reviewed changes
Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@claudiopro claudiopro closed this Jan 28, 2020
@claudiopro
Copy link
Contributor Author

claudiopro commented Jan 28, 2020 •
edited
Loading

Superseded by #2083 which is the correct fix. Thanks @mrkev for resurrecting @lukyth's PR!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@claudiopro @facebook-github-bot