Fix ocaml 4.04 compatibility #156
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Merci petitchevalroux. @phooji can you accept the patch? Seems like I don't have the power to do that anymore. |
|
@aryx you are welcome, i'm glad to contribute :) |
|
Thx @phooji |
As mentionned in #151, there is a compatibilty issue with OCaml 4.04
I'm totally noob to ocaml and c is not my cup of tea (or a really old one) but I take this solution from hhmv (facebook/hhvm@28eefc4)
Don't know if it helps or broke everything but it compiles and sgrep works xD