Bump Gradle minSdk #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51146044 |
Summary: Pull Request resolved: facebookincubator#92 Differential Revision: D51146182
Summary: facebookincubator@bd94aae bumped to NDK 26 (latest LTS NDK). NDK 26 [dropped](https://github.com/android/ndk/wiki/Changelog-r26) [support](android/ndk#1751) for KitKat, and NDK 25 already required minSDK 19, so our minSdk of 15 is too low. This bumps the minSdk, so that when we publish AARs for next fbjni published version, it errors if user is on earlier SDK. Differential Revision: D51146044
NickGerleman
force-pushed
the
export-D51146044
branch
from
ebbdb4c to
1300814
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51146044 |
|
This pull request has been merged in 08a04f0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
bd94aae bumped to NDK 26 (latest LTS NDK).
NDK 26 dropped support for KitKat, and NDK 25 already required minSDK 19, so our minSdk of 15 is too low.
This bumps the minSdk, so that when we publish AARs for next fbjni published version, it errors if user is on earlier SDK.
Differential Revision: D51146044