Migrate from googletest 1.8 to googletest 1.10 (#67)

Summary: Pull Request resolved: #67 Updating `googletest` from `1.8.0` to `1.10.0` Reviewed By: mzlee, igorsugak, luciang, meyering, r-barnes Differential Revision: D34351084 fbshipit-source-id: 939b3985ab63a06b6d511ec8711c2d5863bdfea8
facebookincubator · Mar 3, 2022 · d9411ba · d9411ba
1 parent b9e4278
commit d9411ba
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/build/fbcode_builder/manifests/mvfst b/build/fbcode_builder/manifests/mvfst
@@ -25,7 +25,7 @@ folly
 fizz
 
 [dependencies.all(test=on, not(os=windows))]
-googletest_1_8
+googletest
 
 [shipit.pathmap]
 fbcode/quic/public_root = .

diff --git a/build/fbcode_builder/manifests/proxygen b/build/fbcode_builder/manifests/proxygen
@@ -32,7 +32,7 @@ wangle
 mvfst
 
 [dependencies.test=on]
-googletest_1_8
+googletest
 
 [shipit.pathmap]
 fbcode/proxygen/public_tld = .

diff --git a/server/test/HaskellProcessorTest.cpp b/server/test/HaskellProcessorTest.cpp
@@ -31,18 +31,19 @@ struct MockResponseChannelRequest : public ResponseChannelRequest {
     return true;
   }
 
-  MOCK_METHOD3(
+  MOCK_METHOD(
+      void,
       sendReply,
-      void(
-          ResponsePayload&&,
-          MessageChannel::SendCallback*,
-          folly::Optional<uint32_t>));
+      (ResponsePayload&&,
+       MessageChannel::SendCallback*,
+       folly::Optional<uint32_t>));
 
-  MOCK_METHOD2(
+  MOCK_METHOD(
+      void,
       sendException,
-      void(ResponsePayload&&, MessageChannel::SendCallback*));
+      (ResponsePayload&&, MessageChannel::SendCallback*));
 
-  MOCK_METHOD2(sendErrorWrapped, void(folly::exception_wrapper, std::string));
+  MOCK_METHOD(void, sendErrorWrapped, (folly::exception_wrapper, std::string));
 
   bool active;
   size_t& destroyed;