fix: use button instead of div for navbar toggle button (#64)

facebookincubator · Feb 14, 2021 · e9a3efb · Simek · Feb 15, 2021 · e9a3efb
1 parent 7fc57aa
commit e9a3efb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/core/demo/index.html b/packages/core/demo/index.html
@@ -72,7 +72,7 @@
       <div class="container">
         <div class="navbar__inner">
           <div class="navbar__items">
-            <div class="navbar__toggle" role="button">
+            <button class="navbar__toggle" type="button">
               <svg
                 xmlns="http://www.w3.org/2000/svg"
                 width="30"
@@ -90,7 +90,7 @@
                   d="M4 7h22M4 15h22M4 23h22"
                 ></path>
               </svg>
-            </div>
+            </button>
             <a class="navbar__brand" href="#">
               <img
                 class="navbar__logo"

diff --git a/packages/core/styles/components/navbar.css b/packages/core/styles/components/navbar.css
@@ -83,6 +83,9 @@
     cursor: pointer;
     display: none;
     margin-right: 0.5rem;
+    border: 0;
+    background: 0 0;
+    padding: 0;
 
     @media (--ifm-narrow-window) {
       display: inherit;