Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add .clang-format into repository? #67

Closed
tehnerd opened this issue Dec 20, 2019 · 1 comment
Closed

add .clang-format into repository? #67

tehnerd opened this issue Dec 20, 2019 · 1 comment

Comments

@tehnerd
Copy link
Contributor

tehnerd commented Dec 20, 2019

how hard is it going to be to add clang-format style file into katran's repo? (clang-format -dump-config to generate). right now if i'm running clang-format -i on chaged files i can see lots of unrelated changes. could be because of some custom options of clang-format which is using internally @ fb. would be nice for everyone (internal + external ) to be in sync on how clang-format is configured
facebook-github-bot pushed a commit that referenced this issue Dec 20, 2019
@facebook-github-bot
add clang-format file for katran
54947d9 
Summary: address #67

Reviewed By: yangchi

Differential Revision: D19202524

fbshipit-source-id: 47cdb37453f39bafc2b3bd8a1be94b23ec167abe
@tehnerd
Copy link
Contributor Author

tehnerd commented Dec 21, 2019

Thanks for adding it

@tehnerd tehnerd closed this as completed Dec 21, 2019
facebook-github-bot pushed a commit that referenced this issue Oct 16, 2020
@lukaspiatkowski @facebook-github-bot
mononoke/integration: create a Makefile to run tests as part of getde…
b656b54 
…ps.py build (#67)

Summary:
Pull Request resolved: facebook/sapling#67

With this change it will be possible to build dependencies of and run integration tests using getdeps.py.

This is the first goal of Q4 as per https://fb.quip.com/v8YzAYNSYgot: "Get Open Source version of integration tests running on Legocastle".

Before this diff:
The OSS integration tests run now on GitHub by:
- Building some test dependencies with getdeps.py
- Building some test dependencies with homebrew/apt-get
- Running tests via python script

The OSS integration tests were not running on Sandcastle.

After this diff:
The OSS integration tests run on Github by:
- Building and executing tests via getdeps.py (execution of tests happens by getdeps.py calling Make calling python script)

The OSS integration tests run on Sandcastle using the same getdeps.py setup as Github.

Reviewed By: krallin

Differential Revision: D24253268

fbshipit-source-id: cae249b72d076222673b8bbe4ec21866dcdbb253
facebook-github-bot pushed a commit that referenced this issue Mar 3, 2022
@dimitribouche @facebook-github-bot
Migrate from googletest 1.8 to googletest 1.10 (#67)
e54abd9 
Summary:
X-link: facebookincubator/hsthrift#67

Updating `googletest` from `1.8.0` to `1.10.0`

Reviewed By: mzlee, igorsugak, luciang, meyering, r-barnes

Differential Revision: D34351084

fbshipit-source-id: 939b3985ab63a06b6d511ec8711c2d5863bdfea8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tehnerd