Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema evolution support for reader value hooks #72

Closed
wants to merge 1 commit into from
Closed

Schema evolution support for reader value hooks #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions dwio/nimble/encodings/DictionaryEncoding.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,19 +137,16 @@ class DictionaryIndicesHook : public velox::ValueHook {
return false;
}

void addValue(vector_size_t i, const void* value) final {
indices_[i - offset_] = *reinterpret_cast<const uint32_t*>(value);
void addValue(vector_size_t i, int64_t value) final {
indices_[i - offset_] = value;
}

void addValues(
const vector_size_t* rows,
const void* values,
vector_size_t size,
uint8_t valueWidth) final {
NIMBLE_DASSERT(valueWidth == sizeof(uint32_t), "");
auto* indices = reinterpret_cast<const uint32_t*>(values);
const int32_t* values,
vector_size_t size) final {
for (vector_size_t i = 0; i < size; ++i) {
indices_[rows[i] - offset_] = indices[i];
indices_[rows[i] - offset_] = values[i];
}
}

Expand Down
3 changes: 1 addition & 2 deletions dwio/nimble/encodings/MainlyConstantEncoding.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,7 @@ void MainlyConstantEncoding<T>::bulkScan(
visitor.setRowIndex(visitor.numRows());
if constexpr (V::kHasHook) {
NIMBLE_DASSERT(numValues == numNonNulls, "");
visitor.hook().addValues(
scatterRows, values, numNonNulls, sizeof(ValueType));
visitor.hook().addValues(scatterRows, values, numNonNulls);
} else {
visitor.addNumValues(V::kFilterOnly ? numHits : numValues);
}
Expand Down
3 changes: 1 addition & 2 deletions dwio/nimble/encodings/RleEncoding.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,8 +377,7 @@ void RLEEncoding<T>::bulkScan(
}
if constexpr (V::kHasHook) {
NIMBLE_DASSERT(numValues == numNonNulls, "");
visitor.hook().addValues(
scatterRows, values, numNonNulls, sizeof(ValueType));
visitor.hook().addValues(scatterRows, values, numNonNulls);
} else {
visitor.addNumValues(V::kFilterOnly ? numHits : numValues);
}
Expand Down
Loading