Skip to content

Commit

Permalink
Update regex and globset to pull in memory usage fixes
Browse files Browse the repository at this point in the history
Summary:
BurntSushi has fixed a memory usage regression introduced by regex 1.9 which caused Buck to allocate and retain significantly more memory when using moderately sized `buck2_common::ignores::ignore_set::IgnoreSet` objects concurrently from many threads.

- Bug report: **[rust-lang/regex#1059](rust-lang/regex#1059) *"1.9 memory usage: globset-generated RegexSet allocates and retains 48× more memory (600MB) vs regex 1.8"***

- Globset fix: **[BurntSushi/ripgrep#25770](https://github.com/BurntSushi/ripgrep/pull/25770) *"globset: use non-capture groups in regex transform"***

- Regex fix: **[rust-lang/regex#1062](rust-lang/regex#1062) *"fix memory usage regression for RegexSet with capture groups"***

Reviewed By: zertosh

Differential Revision: D48095372

fbshipit-source-id: ec11c2bcaccbd26354d6d0a0398000134eaf3681
  • Loading branch information
David Tolnay authored and facebook-github-bot committed Aug 5, 2023
1 parent 45dfa28 commit e429137
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ license = "MIT"
anyhow = "1.0.71"
dunce = "1.0.2"
env_logger = "0.10"
globset = { version = "0.4.12", features = ["serde1"] }
globset = { version = "0.4.13", features = ["serde1"] }
ignore = "0.4"
indexmap = { version = "1.9.2", features = ["arbitrary", "rayon", "serde-1"] }
itertools = "0.10.3"
Expand All @@ -22,7 +22,7 @@ nom = "7.1"
once_cell = "1.12"
proc-macro2 = { version = "1.0.64", features = ["span-locations"] }
rayon = "1.2"
regex = "1.6.0"
regex = "1.9.2"
rustsec = { version = "0.26", features = ["fix"] }
semver = { version = "1.0.17", features = ["serde"] }
serde = { version = "1.0.176", features = ["derive", "rc"] }
Expand Down

0 comments on commit e429137

Please sign in to comment.