Skip to content

Commit

Permalink
Delete non-existing injection point in TestValueTest (#4133)
Browse files Browse the repository at this point in the history
Summary:
There is no injection point named
`"facebook::velox::exec::test::TestObject::internalSet"`.

This patch also fixes some typo, and has no functional change.

Pull Request resolved: #4133

Reviewed By: spershin

Differential Revision: D43740387

Pulled By: xiaoxmeng

fbshipit-source-id: 8978a8c3cc233cd4c5142194948b0430bd521a47
  • Loading branch information
lingbin authored and facebook-github-bot committed Mar 3, 2023
1 parent a8b9b60 commit b3493be
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions velox/common/testutil/tests/TestValueTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ class TestObject {

private:
int count_ = 0;
int value_;
int value_ = 0;
};

// NOTE: we can only the testvalue tests on debug build.
// NOTE: we can only build the TestValueTest on debug build.
#ifndef NDEBUG
TEST(TestValueTest, testValueDisabled) {
TestValue::disable();
Expand All @@ -61,7 +61,6 @@ TEST(TestValueTest, testValueDisabled) {
EXPECT_EQ(0, setCount);

TestValue::clear("facebook::velox::exec::test::TestObject::set");
TestValue::clear("facebook::velox::exec::test::TestObject::internalSet");

obj.set(value);
EXPECT_EQ(0, setValue);
Expand Down Expand Up @@ -128,7 +127,7 @@ TEST(TestValueTest, scopeUsageEnabled) {
EXPECT_EQ(value, setValue);
EXPECT_EQ(1, setCount);
}
// Scoped bject dtor will clear the test value settings.
// Scoped object dtor will clear the test value settings.
setCount = 0;
setValue = 0;
obj.set(value + 1);
Expand Down

0 comments on commit b3493be

Please sign in to comment.