Fix NaN handling for min/max aggreates pushed down to scan #10583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This fixes min/max aggregates to handle NaN values correctly when they are pushed down to the scan operator. Specifically, the change ensures that NaN values are considered greater than infinity. Reviewed By: zacw7 Differential Revision: D60297934
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D60297934 |
|
This pull request has been merged in de21ce6. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
37 tasks
weiting-chen
pushed a commit
to weiting-chen/velox
that referenced
this pull request
Nov 23, 2024
…ncubator#10583) Summary: Pull Request resolved: facebookincubator#10583 This fixes min/max aggregates to handle NaN values correctly when they are pushed down to the scan operator. Specifically, the change ensures that NaN values are considered greater than infinity. Reviewed By: zacw7 Differential Revision: D60297934 fbshipit-source-id: 3398ba24d6fc70bbd0d8583d2949391b0824099c
weiting-chen
added a commit
to oap-project/velox
that referenced
this pull request
Nov 23, 2024
…ebookincubator#11298 (#505) * Fix NaN handling for min/max aggreates pushed down to scan (facebookincubator#10583) Summary: Pull Request resolved: facebookincubator#10583 This fixes min/max aggregates to handle NaN values correctly when they are pushed down to the scan operator. Specifically, the change ensures that NaN values are considered greater than infinity. Reviewed By: zacw7 Differential Revision: D60297934 fbshipit-source-id: 3398ba24d6fc70bbd0d8583d2949391b0824099c * Schema evolution support for reader value hooks (facebookincubator#10755) Summary: X-link: facebookincubator/nimble#72 Pull Request resolved: facebookincubator#10755 Currently reader value hook is not considering schema evolution at all, this change fix that. Reviewed By: kevinwilfong Differential Revision: D61229494 fbshipit-source-id: 729bb90611fb3164282b524376eda20985a30194 * Disable aggregate pushdown for decimal type (facebookincubator#11298) Summary: Currently, `int64_t` enables push-down for decimal type. This PR disables aggregate pushdown for decimal type regardless of c++ type. Fixes facebookincubator#11290 Pull Request resolved: facebookincubator#11298 Reviewed By: Yuhta Differential Revision: D65834210 Pulled By: kevinwilfong fbshipit-source-id: 422f7eda8f4184c6fa83055e7cf430ff5053d387 --------- Co-authored-by: Bikramjeet Vig <[email protected]> Co-authored-by: Jimmy Lu <[email protected]> Co-authored-by: NEUpanning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This fixes min/max aggregates to handle NaN values correctly when they are pushed down to the scan operator. Specifically, the change ensures that NaN values are considered greater than infinity.
Reviewed By: zacw7
Differential Revision: D60297934