Fix invalid 'rawResultNulls_' in SelectiveDecimalColumnReader #10925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
reviewed
Sep 4, 2024
| @@ -114,6 +114,13 @@ void SelectiveDecimalColumnReader<DataT>::read( | |||
| VELOX_CHECK(!scanSpec_->filter()); | |||
| VELOX_CHECK(!scanSpec_->valueHook()); | |||
| prepareRead<int64_t>(offset, rows, incomingNulls); | |||
| if (!resultNulls_ || !resultNulls_->unique() || | |||
There was a problem hiding this comment.
You should not need to handle this in column reader subclass like this. Do you have the full stack trace of the exception? resultNulls_ should be kept unallocated only if we can reuse incoming nulls.
There was a problem hiding this comment.
Below is the full stack trace for this exception. Thanks.
# 3 void facebook::velox::detail::veloxCheckFail<facebook::velox::VeloxRuntimeError, facebook::velox::detail::CompileTimeEmptyString>(facebook::velox::detail::VeloxCheckFailArgs const&, facebook::velox::detail::CompileTimeEmptyString)
# 4 void facebook::velox::dwio::common::SelectiveColumnReader::addNull<long>()
# 5 void facebook::velox::dwio::common::ExtractToReader::addNull<long>(int)
# 6 facebook::velox::dwio::common::ColumnVisitor<long, facebook::velox::common::AlwaysTrue, facebook::velox::dwio::common::ExtractToReader, true>::addNull()
# 7 facebook::velox::dwio::common::ColumnVisitor<long, facebook::velox::common::AlwaysTrue, facebook::velox::dwio::common::ExtractToReader, true>::filterPassedForNull()
# 8 facebook::velox::dwio::common::ColumnVisitor<long, facebook::velox::common::AlwaysTrue, facebook::velox::dwio::common::ExtractToReader, true>::processNull(bool&)
# 9 void facebook::velox::dwrf::RleDecoderV2<true>::readWithVisitor<true, facebook::velox::dwio::common::DirectRleColumnVisitor<long, facebook::velox::common::AlwaysTrue, facebook::velox::dwio::common::ExtractToReader, true> >(unsigned long const*, facebook::velox::dwio::common::DirectRleColumnVisitor<long, facebook::velox::common::AlwaysTrue, facebook::velox::dwio::common::ExtractToReader, true>)
# 10 void facebook::velox::dwio::common::SelectiveColumnReader::decodeWithVisitor<facebook::velox::dwrf::RleDecoderV2<true>, facebook::velox::dwio::common::DirectRleColumnVisitor<long, facebook::velox::common::AlwaysTrue, facebook::velox::dwio::common::ExtractToReader, true> >(facebook::velox::dwio::common::IntDecoder<facebook::velox::dwrf::RleDecoderV2<true>::kIsSigned>*, facebook::velox::dwio::common::DirectRleColumnVisitor<long, facebook::velox::common::AlwaysTrue, facebook::velox::dwio::common::ExtractToReader, true>&)
# 11 void facebook::velox::dwrf::SelectiveDecimalColumnReader<long>::readHelper<true>(folly::Range<int const*>)
# 12 facebook::velox::dwrf::SelectiveDecimalColumnReader<long>::read(int, folly::Range<int const*>, unsigned long const*)
# 13 facebook::velox::dwio::common::ColumnLoader::loadInternal(folly::Range<int const*>, facebook::velox::ValueHook*, int, std::shared_ptr<facebook::velox::BaseVector>*)
# 14 facebook::velox::VectorLoader::load(folly::Range<int const*>, facebook::velox::ValueHook*, int, std::shared_ptr<facebook::velox::BaseVector>*)
# 15 facebook::velox::LazyVector::load(folly::Range<int const*>, facebook::velox::ValueHook*) const
# 16 facebook::velox::LazyVector::ensureLoadedRowsImpl(std::shared_ptr<facebook::velox::BaseVector> const&, facebook::velox::DecodedVector&, facebook::velox::SelectivityVector const&, facebook::velox::SelectivityVector&)
# 17 facebook::velox::LazyVector::ensureLoadedRows(std::shared_ptr<facebook::velox::BaseVector> const&, facebook::velox::SelectivityVector const&, facebook::velox::DecodedVector&, facebook::velox::SelectivityVector&)
# 18 facebook::velox::exec::loadColumns(std::shared_ptr<facebook::velox::RowVector> const&, facebook::velox::core::ExecCtx&)
# 19 facebook::velox::exec::CallbackSink::addInput(std::shared_ptr<facebook::velox::RowVector>)
# 20 facebook::velox::exec::Driver::runInternal(std::shared_ptr<facebook::velox::exec::Driver>&, std::shared_ptr<facebook::velox::exec::BlockingState>&, std::shared_ptr<facebook::velox::RowVector>&)
There was a problem hiding this comment.
This should be fixed in #10939
There was a problem hiding this comment.
Thanks for the pointer. Indeed it has been fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes exception caused by invalid 'rawResultNulls_' when reading decimal column
containing null value from ORC file.