-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Spark to_json function #11995
Open
wecharyu
wants to merge
6
commits into
facebookincubator:main
Choose a base branch
from
wecharyu:support_to_json
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+903
−0
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
20a9a15
feat: Add Spark to_json function
wecharyu e0e7f28
remove special form of ToJsonFunction
wecharyu fc6eedd
use buffer for string
wecharyu 6539746
Merge remote-tracking branch 'facebook/main' into support_to_json
wecharyu 8834290
fix conflicts
wecharyu d468270
fix code format
wecharyu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,3 +84,18 @@ JSON Functions | |
SELECT json_object_keys(''); -- NULL | ||
SELECT json_object_keys(1); -- NULL | ||
SELECT json_object_keys('"hello"'); -- NULL | ||
|
||
.. spark:function:: to_json(jsonObject) -> jsonString | ||
|
||
Converts a Json object (ROW, ARRAY or MAP) into a JSON string. | ||
The current implementation has following limitations. | ||
|
||
* Does not support user provided options. :: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would you please provide an example for the unsupported case? |
||
|
||
to_json(ROW(1, "a"), map('option', 'value')) | ||
|
||
Examples of valid inputs are listed as below. :: | ||
|
||
SELECT to_json(ROW(1, "a")); -- {"a":1} | ||
SELECT to_json(ARRAY[1, 2, 3]); -- [1,2,3] | ||
SELECT to_json(MAP(ARRAY['x', 'y'], ARRAY[1, 2])); -- {"x":1,"y":2} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test your change with JsonFunctionsSuite and JsonExpressionsSuite, thanks.