remove unused accounting logic #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Remove the periodic refresh accounting logic and related kill switches. Future diffs will incorporate capping with the optional memory tracker logic and there will never be capping for nodes without accurate accounting. Differential Revision: D30215277 fbshipit-source-id: 207407b7e593b21c32f2f757d512e24e94adc520
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D30215277 |
|
This pull request has been merged in ad1ee8e. |
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Jun 29, 2022
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Jun 30, 2022
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Jul 20, 2022
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Aug 2, 2022
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Aug 12, 2022
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Aug 22, 2022
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Sep 7, 2022
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Sep 26, 2022
rui-mo
added a commit
to rui-mo/velox
that referenced
this pull request
Mar 17, 2023
…ncubator#24) * use config to control cpp building * add a name config for native lib
bdice
added a commit
to bdice/velox
that referenced
this pull request
Dec 19, 2024
* Enable cudf in TPC-H queries. * Draft work on strings conversion. * Improved DATE / logical type support. * Fix for join build to allow multiple batches. * Add environment variables VELOX_CUDF_DISABLED and VELOX_CUDF_DEBUG. * Apply tuning parameters to TPC-H queries to use larger batches when cuDF is enabled. * Add env vars for disabling cudf / enabling debug. * num_drivers=1, num_repeats=1 * Don't reset hashObject_ and only set finished_ to true if noMoreInput_ is true. * Apply tuning parameters to cuDF engine. --------- Co-authored-by: Karthikeyan Natarajan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Remove the periodic refresh accounting logic and related kill switches.
Future diffs will incorporate capping with the optional memory tracker logic and there will never be capping for nodes without accurate accounting.
Differential Revision: D30215277