Add millisecond Presto function #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D31122342 |
aniket486
pushed a commit
to aniket486/velox
that referenced
this pull request
Sep 23, 2021
Summary: Pull Request resolved: facebookincubator#275 Differential Revision: D31122342 fbshipit-source-id: cad933374a0b26580d887841027b24156a8af917
aniket486
force-pushed
the
export-D31122342
branch
from
fe4cb1f to
8af27e9
Compare
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D31122342 |
aniket486
pushed a commit
to aniket486/velox
that referenced
this pull request
Sep 23, 2021
Summary: Pull Request resolved: facebookincubator#275 Reviewed By: mbasmanova Differential Revision: D31122342 fbshipit-source-id: a137f16043ba217364d94df0c4342495cc58792e
aniket486
force-pushed
the
export-D31122342
branch
from
8af27e9 to
4e7bbec
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31122342 |
aniket486
pushed a commit
to aniket486/velox
that referenced
this pull request
Sep 23, 2021
Summary: Pull Request resolved: facebookincubator#275 Reviewed By: mbasmanova Differential Revision: D31122342 fbshipit-source-id: 309ecd52d82fcec0d8b0a38435016d283b55cfe9
aniket486
force-pushed
the
export-D31122342
branch
from
4e7bbec to
6348e06
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31122342 |
biswapesh
reviewed
Sep 25, 2021
| @@ -11,6 +11,10 @@ Date and Time Functions | |||
| Returns the UNIX timestamp ``unixtime`` as a timestamp with time zone | |||
| using ``string`` for the time zone. | |||
|
|
|||
| .. function:: millisecond(timestamp) -> int64 | |||
There was a problem hiding this comment.
Generic question: How are we testing for / ensuring compatibility with the Presto functions, e.g. https://github.com/prestodb/presto/blob/master/presto-main/src/main/java/com/facebook/presto/operator/scalar/DateTimeFunctions.java ?
aniket486
pushed a commit
to aniket486/velox
that referenced
this pull request
Sep 27, 2021
Summary: Pull Request resolved: facebookincubator#275 Reviewed By: mbasmanova Differential Revision: D31122342 fbshipit-source-id: 844e7ad73e34846b4b2d34160b1c4596fc686068
aniket486
force-pushed
the
export-D31122342
branch
from
6348e06 to
1e19e1e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31122342 |
Summary: Pull Request resolved: facebookincubator#275 Reviewed By: mbasmanova Differential Revision: D31122342 fbshipit-source-id: 0d3d2e2989c1714d0021ddc31c842b47ae8827d7
aniket486
force-pushed
the
export-D31122342
branch
from
1e19e1e to
bc58d84
Compare
|
This pull request was exported from Phabricator. Differential Revision: D31122342 |
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Mar 17, 2023
Co-authored-by: BInwei Yang <[email protected]>
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
May 25, 2023
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
May 30, 2023
zhouyuan
pushed a commit
to zhouyuan/velox
that referenced
this pull request
Jun 6, 2023
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D31122342