Free resources in LocalExchangeSourceOperator::close #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbasmanova has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mbasmanova
force-pushed
the
fix-le-close
branch
from
5d23016 to
18817ad
Compare
facebook-github-bot
added
the
CLA Signed
mbasmanova
force-pushed
the
fix-le-close
branch
from
18817ad to
6d17dbc
Compare
|
@mbasmanova has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
pedroerp
approved these changes
Sep 23, 2021
| @@ -120,6 +128,11 @@ class LocalExchangeSourceOperator : public SourceOperator { | |||
|
|
|||
| RowVectorPtr getOutput() override; | |||
|
|
|||
| void close() override { | |||
| Operator::close(); | |||
There was a problem hiding this comment.
not sure if it matters in here, but conceptually, shouldn't we close the specialized resources before we move on to close the parent's resources (what if there's a dependency?)
mbasmanova
force-pushed
the
fix-le-close
branch
from
6d17dbc to
f39cb6e
Compare
|
@mbasmanova has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mbasmanova
force-pushed
the
fix-le-close
branch
from
f39cb6e to
e3616bc
Compare
|
@mbasmanova has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
May 26, 2023
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
May 30, 2023
zhouyuan
pushed a commit
to zhouyuan/velox
that referenced
this pull request
Jun 6, 2023
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.