Fix cases of filter-only column scans A filtered column may or may not #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
A filtered column may or may not produce a value. This is controlled by the ExtractValue template parameter to visitors. If this is dwio::common::DropValues, a buffer for retrieving the value is not allocated. When common parts of the reader were moved to dwio::common, some of the DropValues mentions in dwio::dwrf were not renamed. Also, there was a forward declaration of DropValues in dwio::dwrf, causing the unrenamed locations to continue to compile. In Parquet, when reading multipage RowSets, numValuesBeforePage needs to be the number of passing rows of the RowSet from previous pages, instead of the number of values, as no values are being collected. Adds coverage for filter only columns to E2EFilterTest. One in 5 filtered columns will not be projected out. Accordingly, the column will appear as length 0 in the result. Deals with these in ownership checking and result comparison.
oerling
force-pushed
the
fix-drop-values-pr
branch
from
a1e69c3 to
8c16113
Compare
|
@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@oerling has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cases of filter-only column scan with is (not) null
A filtered column may or may not produce a value. This is controlled
by the ExtractValue template parameter to visitors. If this is
dwio::common::DropValues, a buffer for retrieving the value is not
allocated.
When common parts of the reader were moved to dwio::common, some of
the DropValues mentions in dwio::dwrf were not renamed. Also, there
was a forward declaration of DropValues in dwio::dwrf, causing the unrenamed locations to
continue to compile.
In Parquet, when reading multipage RowSets, numValuesBeforePage needs
to be the number of passing rows of the RowSet from previous pages,
instead of the number of values, as no values are being collected.
Adds coverage for filter only columns to E2EFilterTest. One in 5
filtered columns will not be projected out. Accordingly, the column
will appear as length 0 in the result. Deals with these in ownership
checking and result comparison.