Factor comparison functors out of LeastGreatest.cpp #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D31185337 |
facebook-github-bot
added
the
CLA Signed
Summary: Pull Request resolved: #302 SQL comparisons (<, >, and ==) will be used in many functions. Ideally we'd have these orderings defined in one common locations. In this diff, I put these in a separate header Comparisons.h and update LeastGreatest.cpp to use them. This required a little bit of refactoring. Differential Revision: D31185337 fbshipit-source-id: 05e2fa5ee4fc3d472f57495605765d8d6d0f2b71
|
This pull request was exported from Phabricator. Differential Revision: D31185337 |
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Mar 17, 2023
…okincubator#305) Add a parameter 'spark.gluten.sql.columnar.separate.scan.rdd.for.ch' to control whether to separate scan rdd for ClickHouse Backend. Close facebookincubator#302 .
jackylee-ch
pushed a commit
to jackylee-ch/velox
that referenced
this pull request
Jun 9, 2023
Signed-off-by: Yuan Zhou <[email protected]>
liujiayi771
pushed a commit
to liujiayi771/velox
that referenced
this pull request
Jun 9, 2023
Signed-off-by: Yuan Zhou <[email protected]>
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
Jun 27, 2023
Signed-off-by: Yuan Zhou <[email protected]>
zhli1142015
pushed a commit
to zhli1142015/velox
that referenced
this pull request
Jul 3, 2023
Signed-off-by: Yuan Zhou <[email protected]>
Yohahaha
pushed a commit
to Yohahaha/velox
that referenced
this pull request
Jul 4, 2023
Signed-off-by: Yuan Zhou <[email protected]>
chenxu14
pushed a commit
to chenxu14/velox
that referenced
this pull request
Jul 5, 2023
Signed-off-by: Yuan Zhou <[email protected]>
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
Jul 17, 2023
Signed-off-by: Yuan Zhou <[email protected]>
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 21, 2023
Signed-off-by: Yuan Zhou <[email protected]>
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Jul 24, 2023
Signed-off-by: Yuan Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
SQL comparisons (<, >, and ==) will be used in many functions. Ideally we'd have
these orderings defined in one common locations.
In this diff, I put these in a separate header Comparisons.h and update
LeastGreatest.cpp to use them. This required a little bit of refactoring.
Differential Revision: D31185337