Refactor nullOutput handing in CastExpr #4185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
mbasmanova
commented
Mar 3, 2023
| // Special handling for string target type | ||
| if constexpr (CppToType<To>::typeKind == TypeKind::VARCHAR) { | ||
| if (nullOutput) { |
There was a problem hiding this comment.
This check is wrong. 'nullOutput' is always 'true' here, hence, it never caused a problem.
| // Write the result output to the output vector | ||
| auto writer = exec::StringWriter<>(resultFlatVector, row); |
There was a problem hiding this comment.
This logic should be conditioned on 'nullOutput' being false. It just happens so that Converter::cast never sets 'nullOutput' to true.
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
approved these changes
Mar 3, 2023
|
@mbasmanova merged this pull request in ca411d8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'nullOutput' flag is used only when 'isCastIntByTruncate' is true, which doesn't
seem to be used. A follow-up PR may delete this logic altogether.