Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timezone_hour Presto function #4520

Closed
wants to merge 7 commits into from
Closed

Add timezone_hour Presto function #4520

wants to merge 7 commits into from

Conversation

gopukrishnasIBM
Copy link
Contributor

Resolves #4469

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 5, 2023
@netlify
Copy link

netlify bot commented Apr 5, 2023 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 1a14533
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6448b058263c9a00088ad329

@gopukrishnasIBM gopukrishnasIBM marked this pull request as draft April 5, 2023 15:11
@gopukrishnasIBM gopukrishnasIBM marked this pull request as ready for review April 7, 2023 17:19
@gopukrishnasIBM gopukrishnasIBM self-assigned this Apr 11, 2023
@ashokku2022
Copy link

@aditi-pandit Please review when you get time, thanks!

@gopukrishnasIBM gopukrishnasIBM mentioned this pull request Apr 18, 2023
Closed
mbasmanova
mbasmanova reviewed Apr 18, 2023
View reviewed changes
Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yuhta Jimmy, would you help review this PR?

@mbasmanova mbasmanova requested review from Yuhta and laithsakka April 18, 2023 17:18
@Yuhta Yuhta mentioned this pull request Apr 19, 2023
Closed
@gopukrishnasIBM gopukrishnasIBM requested a review from Yuhta April 20, 2023 15:48
@facebook-github-bot
Copy link
Contributor

@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@gopukrishnasIBM
Copy link
Contributor Author

@Yuhta @mbasmanova Is there anything else I could do here to close the PR?

@facebook-github-bot
Copy link
Contributor

@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Yuhta merged this pull request in 300370f.

@zhejiangxiaomai zhejiangxiaomai mentioned this pull request May 23, 2023
Closed
yiweiHeOSS pushed a commit to yiweiHeOSS/velox that referenced this pull request Jul 15, 2023
@gopukrishnasIBM @yiweiHeOSS
Add timezone_hour Presto function (facebookincubator#4520)
9083ac0 
Summary:
Resolves facebookincubator#4469

Pull Request resolved: facebookincubator#4520

Reviewed By: mbasmanova

Differential Revision: D45188569

Pulled By: Yuhta

fbshipit-source-id: 5760c942ac6942042484d1754c6ce42f30871d2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laithsakka laithsakka Awaiting requested review from laithsakka

@mbasmanova mbasmanova Awaiting requested review from mbasmanova

@Yuhta Yuhta Awaiting requested review from Yuhta

@aditi-pandit aditi-pandit Awaiting requested review from aditi-pandit

Assignees

@gopukrishnasIBM gopukrishnasIBM

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement timezone_hour Presto Function
6 participants
@gopukrishnasIBM @ashokku2022 @facebook-github-bot @Yuhta @mbasmanova @aditi-pandit