Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json_extract Presto function #5269

Closed
wants to merge 2 commits into from

Conversation

mbasmanova
Copy link
Contributor

Add limited version of json_extract Presto function with support for a subset of JSONPath syntax.

@mbasmanova mbasmanova requested a review from xiaoxmeng June 14, 2023 19:21
@netlify
Copy link

netlify bot commented Jun 14, 2023

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit cc977e6
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/648a67637b248300088ee058

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 14, 2023
@mbasmanova mbasmanova requested a review from zacw7 June 14, 2023 19:21
@facebook-github-bot
Copy link
Contributor

@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@mbasmanova mbasmanova requested a review from miaoever June 14, 2023 19:47
velox/functions/prestosql/JsonFunctions.h Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

mbasmanova added a commit to mbasmanova/velox-1 that referenced this pull request Jun 14, 2023
Summary:
Add limited version of json_extract Presto function with support for a subset of JSONPath syntax.

Pull Request resolved: facebookincubator#5269

Reviewed By: zacw7

Differential Revision: D46736261

Pulled By: mbasmanova

fbshipit-source-id: 16f2ec6f04df98d9439a15c06b4836f06c2f2ed2
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46736261

…ator#5267)

Summary:
Presto allows both JSON and VARCHAR values as first argument of json_extract_scalar.

Pull Request resolved: facebookincubator#5267

Differential Revision: D46730166

Pulled By: mbasmanova

fbshipit-source-id: ae822dcfb9b45fedc859fe06deb858e4c2ec663b
Summary:
Add limited version of json_extract Presto function with support for a subset of JSONPath syntax.

Pull Request resolved: facebookincubator#5269

Reviewed By: zacw7

Differential Revision: D46736261

Pulled By: mbasmanova

fbshipit-source-id: c8758aeddc6f7e3997aa503279cbe40620f5925c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D46736261

@facebook-github-bot
Copy link
Contributor

@mbasmanova merged this pull request in 3e6b0dc.

@conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 3e6b0dcd.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants