Cleanup circleci script #8618
Closed
Cleanup circleci script #8618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
Closed
@gaoyangxiaozhu do you know why abfs library install would end up with temporary paths? |
|
@gaoyangxiaozhu, the background is that we installed the dependencies in the CI image. But looks like the azure targets are being linked with temporary build paths. It likely worked before since we were installing the dependencies during the test run time and these paths are still present. |
kgpai
approved these changes
Jan 31, 2024
|
Filed #8622 for the Azure issue. Let's fix that in a separate PR. |
|
@kgpai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
FelixYBW
pushed a commit
to FelixYBW/velox
that referenced
this pull request
Feb 12, 2024
Summary: Pull Request resolved: facebookincubator#8618 Reviewed By: amitkdutta Differential Revision: D53286205 Pulled By: kgpai fbshipit-source-id: 120a25c0903d9aaa0ffdf0e127307f09bc9caefb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now install dependencies in the circle ci image.