Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more test method in Filter::AlwaysFalse class #9718

Closed
wants to merge 1 commit into from
Closed

Add more test method in Filter::AlwaysFalse class #9718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions velox/type/Filter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,10 @@ class AlwaysFalse final : public Filter {
return false;
}

bool testNull() const final {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add tests for these methods? Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say this is too trivial to be tested

return false;
}

bool testInt64(int64_t /* unused */) const final {
return false;
}
Expand All @@ -321,10 +325,19 @@ class AlwaysFalse final : public Filter {
return false;
}

bool testInt128(int128_t /* unused */) const final {
return false;
}

bool testDouble(double /* unused */) const final {
return false;
}

bool testDoubleRange(double /*min*/, double /*max*/, bool /*hasNull*/)
const final {
return false;
}

bool testFloat(float /* unused */) const final {
return false;
}
Expand Down
Loading